Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2106063007: Don't schedule wholeSubtreeInvalid sets. (Closed)

Created:
4 years, 5 months ago by rune
Modified:
4 years, 5 months ago
Reviewers:
esprehn, Eric Willigers
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't schedule wholeSubtreeInvalid sets. The StyleInvalidator asserts if we scheduled such sets. Mark element for SubtreeStyleChange instead. R=esprehn@chromium.org,ericwilligers@chromium.org BUG=624607 Committed: https://crrev.com/1405b49c739b32c53d57ede4600c9ed7dca5c6af Cr-Commit-Position: refs/heads/master@{#403663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/css/invalidation/sibling-mutation-assert.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
rune
4 years, 5 months ago (2016-07-01 23:55:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106063007/1
4 years, 5 months ago (2016-07-01 23:55:59 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-02 01:19:24 UTC) #5
Eric Willigers
lgtm
4 years, 5 months ago (2016-07-03 23:40:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106063007/1
4 years, 5 months ago (2016-07-04 10:09:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 11:21:56 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-04 11:22:04 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 11:23:26 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1405b49c739b32c53d57ede4600c9ed7dca5c6af
Cr-Commit-Position: refs/heads/master@{#403663}

Powered by Google App Engine
This is Rietveld 408576698