Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2106063006:
[Android] Make host_info.py use device_status.py instead of bb_device_status_check.py (Closed)
|
Created:
4 years, 5 months ago by rnephew (Reviews Here) Modified:
4 years, 5 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Android] Make host_info.py use device_status.py instead of bb_device_status_check.py
BUG=592140
Committed: https://crrev.com/4991dac3c60adfa126c70b3988ea4d2f5456351d
Cr-Commit-Position: refs/heads/master@{#403941}
Patch Set 1 : ~ #
Total comments: 2
Patch Set 2 : move constant to common #
Messages
Total messages: 24 (11 generated)
rnephew@chromium.org changed reviewers: + jbudorick@chromium.org, mikecase@chromium.org
Patchset #1 (id:1) has been deleted
lgtm
The CQ bit was checked by rnephew@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
rnephew@chromium.org changed reviewers: + iannucci@chromium.org, phajdan.jr@chromium.org
rnephew@chromium.org changed reviewers: + dpranke@chromium.org
LGTM w/comment https://codereview.chromium.org/2106063006/diff/20001/testing/scripts/host_in... File testing/scripts/host_info.py (right): https://codereview.chromium.org/2106063006/diff/20001/testing/scripts/host_in... testing/scripts/host_info.py:16: INFRA_EXIT_CODE = 87 Can we move that to testing/scripts/common? I'd also suggest rename to INFRA_FAILURE_EXIT_CODE.
https://codereview.chromium.org/2106063006/diff/20001/testing/scripts/host_in... File testing/scripts/host_info.py (right): https://codereview.chromium.org/2106063006/diff/20001/testing/scripts/host_in... testing/scripts/host_info.py:16: INFRA_EXIT_CODE = 87 On 2016/07/04 10:38:08, Paweł Hajdan Jr. wrote: > Can we move that to testing/scripts/common? I'd also suggest rename to > INFRA_FAILURE_EXIT_CODE. Done.
The CQ bit was checked by rnephew@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jbudorick@chromium.org, phajdan.jr@chromium.org Link to the patchset: https://codereview.chromium.org/2106063006/#ps40001 (title: "move constant to common")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by rnephew@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Android] Make host_info.py use device_status.py instead of bb_device_status_check.py BUG=592140 ========== to ========== [Android] Make host_info.py use device_status.py instead of bb_device_status_check.py BUG=592140 Committed: https://crrev.com/4991dac3c60adfa126c70b3988ea4d2f5456351d Cr-Commit-Position: refs/heads/master@{#403941} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4991dac3c60adfa126c70b3988ea4d2f5456351d Cr-Commit-Position: refs/heads/master@{#403941} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
