Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2106063005: Split apart the GP construction for the NonAAFillRect Batches (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Split apart the GP construction for the NonAAFillRect Batches This sets up for adding yet another batch type that specializes for rectStaysRect GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2106063005 Committed: https://skia.googlesource.com/skia/+/6abd1d192e0b2698d19e0b03fe4c2a34fb604b8f

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update to ToT #

Patch Set 4 : Update to ToT (again) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M src/gpu/batches/GrNonAAFillRectBatch.cpp View 1 2 3 8 chunks +27 lines, -16 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
robertphillips
4 years, 5 months ago (2016-07-01 14:35:01 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106063005/40001
4 years, 5 months ago (2016-07-01 14:53:09 UTC) #6
bsalomon
lgtm
4 years, 5 months ago (2016-07-01 14:55:09 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/9414)
4 years, 5 months ago (2016-07-01 15:09:54 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106063005/60001
4 years, 5 months ago (2016-07-01 15:32:57 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-01 15:53:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106063005/60001
4 years, 5 months ago (2016-07-01 16:06:02 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 16:06:59 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6abd1d192e0b2698d19e0b03fe4c2a34fb604b8f

Powered by Google App Engine
This is Rietveld 408576698