Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2106043002: Disable failing embedder tests for Skia builds. (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
4 years, 5 months ago
Reviewers:
caryclark
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M core/fpdfapi/fpdf_render/fpdf_render_loadimage_embeddertest.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_pattern_embeddertest.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Lei Zhang
4 years, 5 months ago (2016-06-29 05:14:07 UTC) #2
caryclark
lgtm Thanks for doing this. I'll track down the failures and fix them.
4 years, 5 months ago (2016-06-29 11:38:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106043002/1
4 years, 5 months ago (2016-06-29 13:47:31 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 13:47:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/0efab9428fe9fe0a1af4f8eba9fabb78b1ee...

Powered by Google App Engine
This is Rietveld 408576698