Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2699)

Unified Diff: chrome/browser/resources/settings/settings_page_css.html

Issue 2106013002: Move settings-section animations into setting-section, make better (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Transitions
Patch Set: Refactor Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_page_css.html
diff --git a/chrome/browser/resources/settings/settings_page_css.html b/chrome/browser/resources/settings/settings_page_css.html
index 160470e9e9f1bcacf62a9875a117486ccd5ca325..66e06fccf8dc0e8a8f6eeff5acb0981fcccfedad 100644
--- a/chrome/browser/resources/settings/settings_page_css.html
+++ b/chrome/browser/resources/settings/settings_page_css.html
@@ -15,6 +15,11 @@
width: 96%;
}
+ :host(.showing-subpage) {
+ /* Set the height to the container height so the subpage scrolls. */
+ height: 100%;
+ }
+
:host > div {
height: inherit;
}
@@ -27,12 +32,12 @@
margin-bottom: 3px;
}
- .expanded {
+ settings-section.expanded {
min-height: 100%;
}
- .expanding,
- .collapsing {
+ settings-section.expanding,
+ settings-section.collapsing {
Dan Beam 2016/08/05 00:47:07 why are you adding this? i had to remove a tag na
/* Must be lower than the paper-header-panel's z-index.
* See settings_ui.html. */
z-index: 1;

Powered by Google App Engine
This is Rietveld 408576698