Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4814)

Unified Diff: chrome/browser/resources/settings/settings_page/compiled_resources2.gyp

Issue 2106013002: Move settings-section animations into setting-section, make better (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Transitions
Patch Set: Refactor Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_page/compiled_resources2.gyp
diff --git a/chrome/browser/resources/settings/settings_page/compiled_resources2.gyp b/chrome/browser/resources/settings/settings_page/compiled_resources2.gyp
index f47f367afdc6f7d26041f6b866d84927cacb1ef6..7162b0030e8d5c2c14f77e51ef95958b6d8ed3c4 100644
--- a/chrome/browser/resources/settings/settings_page/compiled_resources2.gyp
+++ b/chrome/browser/resources/settings/settings_page/compiled_resources2.gyp
@@ -7,9 +7,17 @@
'target_name': 'main_page_behavior',
'dependencies': [
'settings_section',
- 'transition_behavior',
+ 'open_section_transition',
'<(EXTERNS_GYP):settings_private',
- '<(EXTERNS_GYP):web_animations',
+ '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:util',
+ ],
+ 'includes': ['../../../../../third_party/closure_compiler/compile_js2.gypi'],
+ },
+ {
+ 'target_name': 'open_section_transition',
+ 'dependencies': [
+ 'settings_section',
+ '../animation/compiled_resources2.gyp:animation_group',
'<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:util',
],
'includes': ['../../../../../third_party/closure_compiler/compile_js2.gypi'],
@@ -38,6 +46,9 @@
},
{
'target_name': 'settings_section',
+ 'dependencies': [
+ '../animation/compiled_resources2.gyp:animation',
+ ],
'includes': ['../../../../../third_party/closure_compiler/compile_js2.gypi'],
},
{
@@ -60,13 +71,5 @@
],
'includes': ['../../../../../third_party/closure_compiler/compile_js2.gypi'],
},
- {
- 'target_name': 'transition_behavior',
- 'dependencies': [
- '<(EXTERNS_GYP):settings_private',
- '<(EXTERNS_GYP):web_animations',
- ],
- 'includes': ['../../../../../third_party/closure_compiler/compile_js2.gypi'],
- },
],
}

Powered by Google App Engine
This is Rietveld 408576698