Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4346)

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 2106013002: Move settings-section animations into setting-section, make better (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Transitions
Patch Set: Refactor Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_main/settings_main.html
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html
index 73566ff621890227a5a4de7e7e57167d2c48b407..9abb1e6d47cec474a570b1ea3b10347e5f462512 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.html
+++ b/chrome/browser/resources/settings/settings_main/settings_main.html
@@ -56,13 +56,15 @@
</div>
<template is="dom-if" if="[[showPages_.basic]]">
<settings-basic-page prefs="{{prefs}}" current-route="{{currentRoute}}"
- page-visibility="[[pageVisibility]]">
+ page-visibility="[[pageVisibility]]"
+ on-subpage-expand="onSubpageExpand_">
</settings-basic-page>
</template>
<template is="dom-if"
if="[[showAdvancedSettings_(pageVisibility.advancedSettings)]]">
+
dschuyler 2016/08/04 18:36:51 I'm fine with a blank line or not having a blank l
<template is="dom-if"
- if="[[showAdvancedToggle_(showPages_.basic, inSubpage_)]]">
+ if="[[showAdvancedToggle_(showPages_.basic, hasExpandedSection_)]]">
<div id="toggleSpacer"></div>
<div id="toggleContainer" hidden$="[[showNoResultsFound_]]">
<div id="advancedToggle" on-tap="toggleAdvancedPage_">
@@ -74,7 +76,8 @@
<template is="dom-if" if="[[showPages_.advanced]]">
<settings-advanced-page prefs="{{prefs}}"
current-route="{{currentRoute}}"
- page-visibility="[[pageVisibility]]">
+ page-visibility="[[pageVisibility]]"
+ on-subpage-expand="onSubpageExpand_">
</settings-advanced-page>
</template>
</template>

Powered by Google App Engine
This is Rietveld 408576698