Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 2106013002: Move settings-section animations into setting-section, make better (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Transitions
Patch Set: cleanup Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_main/settings_main.html
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html
index dfeb94f5a941282eff64d48c58730a8d1e484617..d22ef1ccb0cfcdda9015828e33d5818d0e0696e4 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.html
+++ b/chrome/browser/resources/settings/settings_main/settings_main.html
@@ -37,7 +37,9 @@
</style>
<content select="paper-icon-button"></content>
<template is="dom-if" if="[[showBasicPage_]]">
- <settings-basic-page prefs="{{prefs}}" current-route="{{currentRoute}}">
+ <settings-basic-page prefs="{{prefs}}" current-route="{{currentRoute}}"
+ on-subpage-expand="subpageExpanded_"
michaelpg 2016/06/28 23:45:16 dschuyler, please take a look at these changes. We
+ on-subpage-collapsing="subpageCollapsing_">
</settings-basic-page>
</template>
<template is="dom-if" if="[[showAdvancedToggle_]]">
@@ -51,7 +53,9 @@
</template>
<template is="dom-if" if="[[showAdvancedPage_]]">
<settings-advanced-page prefs="{{prefs}}"
- current-route="{{currentRoute}}">
+ current-route="{{currentRoute}}"
+ on-subpage-expand="subpageExpanded_"
+ on-subpage-collapsing="subpageCollapsing_">
</settings-advanced-page>
</template>
<template is="dom-if" if="[[showAboutPage_]]">

Powered by Google App Engine
This is Rietveld 408576698