Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7024)

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 2106013002: Move settings-section animations into setting-section, make better (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Transitions
Patch Set: Reworked properties/rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_main/settings_main.html
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html
index cd9239022e2d18962d77b332e60101eb23b3afae..898015bb9ade872b6c27d1ad518fb8bac0e3f167 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.html
+++ b/chrome/browser/resources/settings/settings_main/settings_main.html
@@ -40,7 +40,9 @@
<content select="paper-icon-button"></content>
<template is="dom-if" if="[[!showAboutPage_]]">
<template is="dom-if" if="[[showBasicPage_]]">
- <settings-basic-page prefs="{{prefs}}" current-route="{{currentRoute}}">
+ <settings-basic-page prefs="{{prefs}}" current-route="{{currentRoute}}"
+ on-subpage-expand="subpageExpanded_"
+ on-subpage-collapsing="subpageCollapsing_">
</settings-basic-page>
</template>
<div hidden$="[[inSubpage_]]">
@@ -54,7 +56,9 @@
</div>
<template is="dom-if" if="[[showAdvancedPage_]]">
<settings-advanced-page prefs="{{prefs}}"
- current-route="{{currentRoute}}">
+ current-route="{{currentRoute}}"
+ on-subpage-expand="subpageExpanded_"
+ on-subpage-collapsing="subpageCollapsing_">
</settings-advanced-page>
</template>
</template>

Powered by Google App Engine
This is Rietveld 408576698