chrome/browser/resources/settings/settings_page/settings_section.html - Issue 2106013002: Move settings-section animations into setting-section, make better

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_section.html

Issue 2106013002: Move settings-section animations into setting-section, make better (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Transitions

Patch Set: Computed properties Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/settings_page/main_page_behavior.js ('K') | « chrome/browser/resources/settings/settings_page/open_section_transition.js ('k') | chrome/browser/resources/settings/settings_page/transition_behavior.html » ('j') | chrome/test/data/webui/settings/open_section_transition_browsertest.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_section.html

diff --git a/chrome/browser/resources/settings/settings_page/settings_section.html b/chrome/browser/resources/settings/settings_page/settings_section.html

index 2df5028c85a5ab0d1b797350483dd7c27cdb819a..69b6303815a5e9bbe3a16d75bd40661f0a1e2cd4 100644

--- a/chrome/browser/resources/settings/settings_page/settings_section.html

+++ b/chrome/browser/resources/settings/settings_page/settings_section.html

@@ -8,6 +8,8 @@

:host {

display: flex;

flex-direction: column;

+ /** Margin so the box-shadow isn't clipped during animations. */

Dan Beam 2016/07/12 02:01:54 nit: /*

michaelpg 2016/07/20 22:10:57 Done.

+ margin: 0 3px;

position: relative;

}