Move settings-section animations into setting-section, make better

chrome/browser/resources/settings/settings_main/settings_main.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-main' displays the selected settings page.
  */
 Polymer({
   is: 'settings-main',
@@ skipping 91 matching lines @@
 
   /**
    * @param {!SettingsRoute} newRoute
    * @private
    */
   currentRouteChanged_: function(newRoute) {
     var isSubpage = !!newRoute.subpage.length;
 
     this.showAboutPage_ = newRoute.page == 'about';
 
-    this.showAdvancedToggle_ = !this.showAboutPage_ && !isSubpage;
+    this.showAdvancedToggle_ = !this.showAboutPage_;
 
-    this.showBasicPage_ = this.showAdvancedToggle_ || newRoute.page == 'basic';
+    this.showBasicPage_ = !this.showAboutPage_;
 
-    this.showAdvancedPage_ =
+    this.showAdvancedPage_ = this.showAdvancedPage_ ||
         (this.isAdvancedMenuOpen_ && this.showAdvancedToggle_) ||
         newRoute.page == 'advanced';

[Dan Beam, 2016/07/07 18:15:38]

should all of these be computed separtely with their own dependencies?  i.e.

showAdvancedPage_: {
  computed: 'computeShowAdvancedPage_(isAdvancedMenuOpen_, '
                                     'showAdvancedToggle_, ' +
                                     'currentRoute)',
},

i think it'd be a little less error prone if these were computed separately at
this point

[michaelpg, 2016/07/08 00:19:02]

Done, great suggestion!

+  },
 

[Dan Beam, 2016/07/07 18:15:38]

/** @private */

[michaelpg, 2016/07/08 00:19:02]

Done.

-    this.style.height = isSubpage ? '100%' : '';
+  subpageExpanded_: function() {
+    this.showBasicPage_ = this.currentRoute.page == 'basic';
+    this.showAdvancedPage_ = !this.showBasicPage_;
+    this.showAdvancedToggle_ = false;
+  },
+
+  subpageCollapsing_: function() {
+    this.currentRouteChanged_(this.currentRoute);
   },
 
   /** @private */
   toggleAdvancedPage_: function() {
     this.fire('toggle-advanced-page', !this.isAdvancedMenuOpen_);
   },
 });