Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2105963002: Make LayoutObject::showLayoutTreeForThis Windows-friendly. (Closed)

Created:
4 years, 5 months ago by szager1
Modified:
4 years, 5 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make LayoutObject::showLayoutTreeForThis Windows-friendly. fprintf(stderr) goes into a black hole when debugging on Windows. Switch to WTFLogAlways, which has win-specific smarts. R=eae@chromium.org Committed: https://crrev.com/82c8d75acd617922bac530d2986c048b9e11102d Cr-Commit-Position: refs/heads/master@{#402657}

Patch Set 1 #

Patch Set 2 : Get rid of all printfs #

Patch Set 3 : comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 4 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
szager1
4 years, 5 months ago (2016-06-28 21:37:36 UTC) #1
eae
Awesome! LGTM
4 years, 5 months ago (2016-06-28 21:38:45 UTC) #2
szager1
Got rid of a few more printf's, PTAL.
4 years, 5 months ago (2016-06-28 22:27:12 UTC) #3
eae
Nice, still LGTM
4 years, 5 months ago (2016-06-28 22:44:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105963002/40001
4 years, 5 months ago (2016-06-28 22:47:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/247170)
4 years, 5 months ago (2016-06-29 00:41:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105963002/40001
4 years, 5 months ago (2016-06-29 00:44:03 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 02:13:19 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/82c8d75acd617922bac530d2986c048b9e11102d Cr-Commit-Position: refs/heads/master@{#402657}
4 years, 5 months ago (2016-06-29 02:15:39 UTC) #13
tkent
4 years, 5 months ago (2016-06-29 04:09:27 UTC) #14
Message was sent while issue was closed. 
Pleas avoid to use WTFLog*().  We'd like to remove it in favor of
base/logging.h.

Powered by Google App Engine
This is Rietveld 408576698