Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: src/api.cc

Issue 2105943002: Expose TickSample and its APIs in v8-profiler.h (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase & address comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 86135fd83d2ab6460a8e96665a651f8a1af42f05..b280f0af23b20adda6e732cb21f402154f9bae3a 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -36,6 +36,7 @@
#include "src/debug/debug.h"
#include "src/deoptimizer.h"
#include "src/execution.h"
+#include "src/frames-inl.h"
#include "src/gdb-jit.h"
#include "src/global-handles.h"
#include "src/icu_util.h"
@@ -7564,8 +7565,8 @@ bool Isolate::GetHeapCodeAndMetadataStatistics(
void Isolate::GetStackSample(const RegisterState& state, void** frames,
size_t frames_limit, SampleInfo* sample_info) {
- i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
#if defined(USE_SIMULATOR)
+ i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
RegisterState regs;
regs.pc = state.pc;
alph 2016/06/29 19:39:09 Hmm, how these got here??? Can you please drop the
lpy 2016/06/29 20:17:39 Done.
regs.sp = state.sp;
@@ -7579,8 +7580,8 @@ void Isolate::GetStackSample(const RegisterState& state, void** frames,
#else
const RegisterState& regs = state;
#endif
- i::TickSample::GetStackSample(isolate, regs, i::TickSample::kSkipCEntryFrame,
- frames, frames_limit, sample_info);
+ TickSample::GetStackSample(this, regs, TickSample::kSkipCEntryFrame, frames,
+ frames_limit, sample_info);
}
size_t Isolate::NumberOfPhantomHandleResetsSinceLastCall() {

Powered by Google App Engine
This is Rietveld 408576698