Expose TickSample and its APIs in v8-profiler.h

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/api.h"
 
 #include <string.h>  // For memcpy, strlen.
 #ifdef V8_USE_ADDRESS_SANITIZER
 #include <sanitizer/asan_interface.h>
 #endif  // V8_USE_ADDRESS_SANITIZER
@@ skipping 18 matching lines @@
 #include "src/char-predicates-inl.h"
 #include "src/code-stubs.h"
 #include "src/compiler.h"
 #include "src/context-measure.h"
 #include "src/contexts.h"
 #include "src/conversions-inl.h"
 #include "src/counters.h"
 #include "src/debug/debug.h"
 #include "src/deoptimizer.h"
 #include "src/execution.h"
+#include "src/frames-inl.h"
 #include "src/gdb-jit.h"
 #include "src/global-handles.h"
 #include "src/icu_util.h"
 #include "src/isolate-inl.h"
 #include "src/json-parser.h"
 #include "src/json-stringifier.h"
 #include "src/messages.h"
 #include "src/parsing/parser.h"
 #include "src/parsing/scanner-character-streams.h"
 #include "src/pending-compilation-error-handler.h"
@@ skipping 7513 matching lines @@
   isolate->heap()->CollectCodeStatistics();
 
   code_statistics->code_and_metadata_size_ = isolate->code_and_metadata_size();
   code_statistics->bytecode_and_metadata_size_ =
       isolate->bytecode_and_metadata_size();
   return true;
 }
 
 void Isolate::GetStackSample(const RegisterState& state, void** frames,
                              size_t frames_limit, SampleInfo* sample_info) {
+#if defined(USE_SIMULATOR)
   i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
-#if defined(USE_SIMULATOR)
-  RegisterState regs;
-  regs.pc = state.pc;
-  regs.sp = state.sp;
-  regs.fp = state.fp;
-  if (!i::SimulatorHelper::FillRegisters(isolate, &regs)) {
+  if (!i::SimulatorHelper::FillRegisters(isolate,
+                                         const_cast<RegisterState*>(&state))) {

[alph, 2016/06/30 21:18:08]

please avoid using const_cast, as the caller is not expecting you to change the
state.
Bring back the regs variable.

[lpy, 2016/06/30 22:51:29]

Done.

     sample_info->frames_count = 0;
     sample_info->vm_state = OTHER;
     sample_info->external_callback_entry = nullptr;
     return;
   }
-#else
-  const RegisterState& regs = state;
 #endif
-  i::TickSample::GetStackSample(isolate, regs, i::TickSample::kSkipCEntryFrame,
-                                frames, frames_limit, sample_info);
+  TickSample::GetStackSample(this, state, TickSample::kSkipCEntryFrame, frames,
+                             frames_limit, sample_info);
 }
 
 size_t Isolate::NumberOfPhantomHandleResetsSinceLastCall() {
   i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
   size_t result = isolate->global_handles()->NumberOfPhantomHandleResets();
   isolate->global_handles()->ResetNumberOfPhantomHandleResets();
   return result;
 }
 
 void Isolate::SetEventLogger(LogEventCallback that) {
@@ skipping 1330 matching lines @@
   Address callback_address =
       reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
   VMState<EXTERNAL> state(isolate);
   ExternalCallbackScope call_scope(isolate, callback_address);
   callback(info);
 }
 
 
 }  // namespace internal
 }  // namespace v8