Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3369)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java

Issue 2105933002: NTP: Fix metrics recording crash by plumbing the necessary data to Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java
index 617f727423def0236bc2dbb8194da526510d745f..185e5e432ce65064909b8c739112a415189c886b 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java
@@ -19,6 +19,8 @@ public class FakeMostVisitedSites extends MostVisitedSites {
private final String[] mMostVisitedTitles;
private final String[] mMostVisitedUrls;
private final String[] mMostVisitedWhitelistIconPaths;
+ private final int[] mMostVisitedSources;
+ private final int[] mMostVisitedProviderIndexes;
private final List<String> mBlacklistedUrls = new ArrayList<String>();
@@ -28,12 +30,15 @@ public class FakeMostVisitedSites extends MostVisitedSites {
* @param mostVisitedUrls The URLs of the fixed list of most visited sites.
*/
public FakeMostVisitedSites(Profile p, String[] mostVisitedTitles, String[] mostVisitedUrls,
- String[] mostVisitedWhitelistIconPaths) {
+ String[] mostVisitedWhitelistIconPaths, int[] mostVisitedSources,
+ int[] mostVisitedProviderIndexes) {
super(p);
assert mostVisitedTitles.length == mostVisitedUrls.length;
mMostVisitedTitles = mostVisitedTitles.clone();
mMostVisitedUrls = mostVisitedUrls.clone();
mMostVisitedWhitelistIconPaths = mostVisitedWhitelistIconPaths.clone();
+ mMostVisitedSources = mostVisitedSources.clone();
+ mMostVisitedProviderIndexes = mostVisitedProviderIndexes.clone();
}
@Override
@@ -42,7 +47,8 @@ public class FakeMostVisitedSites extends MostVisitedSites {
@Override
public void run() {
observer.onMostVisitedURLsAvailable(mMostVisitedTitles.clone(),
- mMostVisitedUrls.clone(), mMostVisitedWhitelistIconPaths.clone());
+ mMostVisitedUrls.clone(), mMostVisitedWhitelistIconPaths.clone(),
+ mMostVisitedSources.clone(), mMostVisitedProviderIndexes.clone());
}
});
}
@@ -65,11 +71,6 @@ public class FakeMostVisitedSites extends MostVisitedSites {
}
@Override
- public void recordTileTypeMetrics(int[] tileTypes) {
- // Metrics are stubbed out.
- }
-
- @Override
public void recordOpenedMostVisitedItem(int index, int tileType) {
// Metrics are stubbed out.
}

Powered by Google App Engine
This is Rietveld 408576698