chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java - Issue 2105933002: NTP: Fix metrics recording crash by plumbing the necessary data to Java.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

Issue 2105933002: NTP: Fix metrics recording crash by plumbing the necessary data to Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address treib@ comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java ('k') | chrome/browser/android/ntp/most_visited_sites_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

index 3a94395b06bc52698451ae6b4abea4a2562f095a..41e70610ee610f91a0fb69c3a7fdc1fde8899d72 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

@@ -50,6 +50,8 @@ public class NewTabPageTest extends ChromeTabbedActivityTestBase {

private static final String[] FAKE_MOST_VISITED_TITLES = new String[] { "Simple" };

private static final String[] FAKE_MOST_VISITED_WHITELIST_ICON_PATHS = new String[] { "" };

+ private static final int[] FAKE_MOST_VISITED_SOURCES = new int[] {MostVisitedSource.TOP_SITES};

+ private static final int[] FAKE_MOST_VISITED_PROVIDER_INDEXES = new int[] {0};

private Tab mTab;

private NewTabPage mNtp;

@@ -86,7 +88,8 @@ public class NewTabPageTest extends ChromeTabbedActivityTestBase {

// native code.

mFakeMostVisitedSites =

new FakeMostVisitedSites(mTab.getProfile(), FAKE_MOST_VISITED_TITLES,

- mFakeMostVisitedUrls, FAKE_MOST_VISITED_WHITELIST_ICON_PATHS);

+ mFakeMostVisitedUrls, FAKE_MOST_VISITED_WHITELIST_ICON_PATHS,

+ FAKE_MOST_VISITED_SOURCES, FAKE_MOST_VISITED_PROVIDER_INDEXES);

}

});

} catch (Throwable t) {