Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2966)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java

Issue 2105933002: NTP: Fix metrics recording crash by plumbing the necessary data to Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address treib@ comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java b/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
index c60da0ae7ca6e72d6c92953013be6e3d3bbf7c1f..e9e02d512fdb45c22c4e27970eb68d01b1ca4ef0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
@@ -27,8 +27,8 @@ public class MostVisitedSites {
* visited URLs).
*/
@CalledByNative("MostVisitedURLsObserver")
- public void onMostVisitedURLsAvailable(
- String[] titles, String[] urls, String[] whitelistIconPaths);
+ public void onMostVisitedURLsAvailable(String[] titles, String[] urls,
+ String[] whitelistIconPaths, int[] sources, int[] providerIndexes);
/**
* This is called when the list of popular URLs is initially available or updated.
@@ -72,11 +72,12 @@ public class MostVisitedSites {
public void setMostVisitedURLsObserver(final MostVisitedURLsObserver observer, int numSites) {
MostVisitedURLsObserver wrappedObserver = new MostVisitedURLsObserver() {
@Override
- public void onMostVisitedURLsAvailable(
- String[] titles, String[] urls, String[] whitelistIconPaths) {
+ public void onMostVisitedURLsAvailable(String[] titles, String[] urls,
+ String[] whitelistIconPaths, int[] sources, int[] providerIndexes) {
// Don't notify observer if we've already been destroyed.
if (mNativeMostVisitedSitesBridge != 0) {
- observer.onMostVisitedURLsAvailable(titles, urls, whitelistIconPaths);
+ observer.onMostVisitedURLsAvailable(
+ titles, urls, whitelistIconPaths, sources, providerIndexes);
}
}
@Override
@@ -111,8 +112,9 @@ public class MostVisitedSites {
* @param tileTypes An array of values from MostVisitedTileType indicating the type of each
* tile that's currently showing.
*/
- public void recordTileTypeMetrics(int[] tileTypes) {
- nativeRecordTileTypeMetrics(mNativeMostVisitedSitesBridge, tileTypes);
+ public void recordTileTypeMetrics(int[] tileTypes, int[] sources, int[] providerIndices) {
+ nativeRecordTileTypeMetrics(
+ mNativeMostVisitedSitesBridge, tileTypes, sources, providerIndices);
}
/**
@@ -131,8 +133,8 @@ public class MostVisitedSites {
private native void nativeAddOrRemoveBlacklistedUrl(
long nativeMostVisitedSitesBridge, String url,
boolean addUrl);
- private native void nativeRecordTileTypeMetrics(
- long nativeMostVisitedSitesBridge, int[] tileTypes);
+ private native void nativeRecordTileTypeMetrics(long nativeMostVisitedSitesBridge,
+ int[] tileTypes, int[] sources, int[] providerIndices);
private native void nativeRecordOpenedMostVisitedItem(
long nativeMostVisitedSitesBridge, int index, int tileType);

Powered by Google App Engine
This is Rietveld 408576698