chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java - Issue 2105933002: NTP: Fix metrics recording crash by plumbing the necessary data to Java.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2105933002: NTP: Fix metrics recording crash by plumbing the necessary data to Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address treib@ comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

index c5db19d1d64b83536cdfe2436b8c25c64f3988f7..7fb07fb4ab253b471d5d51383b1366f48392bee5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

@@ -533,10 +533,16 @@ public class NewTabPage

if (!mTab.isHidden()) recordNTPShown();

int tileTypes[] = new int[items.length];

+ int sources[] = new int[items.length];

+ int providerIndices[] = new int[items.length];

for (int i = 0; i < items.length; i++) {

tileTypes[i] = items[i].getTileType();

+ sources[i] = items[i].getSource();

+ providerIndices[i] = items[i].getProviderIndex();

}

- mMostVisitedSites.recordTileTypeMetrics(tileTypes);

+ mMostVisitedSites.recordTileTypeMetrics(tileTypes, sources, providerIndices);

if (isNtpOfflinePagesEnabled()) {

final int maxNumTiles = 12;