Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: chrome/browser/android/ntp/most_visited_sites_bridge.h

Issue 2105933002: NTP: Fix metrics recording crash by plumbing the necessary data to Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_NTP_MOST_VISITED_SITES_BRIDGE_H_ 5 #ifndef CHROME_BROWSER_ANDROID_NTP_MOST_VISITED_SITES_BRIDGE_H_
6 #define CHROME_BROWSER_ANDROID_NTP_MOST_VISITED_SITES_BRIDGE_H_ 6 #define CHROME_BROWSER_ANDROID_NTP_MOST_VISITED_SITES_BRIDGE_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 #include <stddef.h> 9 #include <stddef.h>
10 10
(...skipping 20 matching lines...) Expand all
31 JNIEnv* env, 31 JNIEnv* env,
32 const base::android::JavaParamRef<jobject>& obj, 32 const base::android::JavaParamRef<jobject>& obj,
33 const base::android::JavaParamRef<jobject>& j_observer, 33 const base::android::JavaParamRef<jobject>& j_observer,
34 jint num_sites); 34 jint num_sites);
35 35
36 void AddOrRemoveBlacklistedUrl( 36 void AddOrRemoveBlacklistedUrl(
37 JNIEnv* env, 37 JNIEnv* env,
38 const base::android::JavaParamRef<jobject>& obj, 38 const base::android::JavaParamRef<jobject>& obj,
39 const base::android::JavaParamRef<jstring>& j_url, 39 const base::android::JavaParamRef<jstring>& j_url,
40 jboolean add_url); 40 jboolean add_url);
41 void RecordTileTypeMetrics(
42 JNIEnv* env,
43 const base::android::JavaParamRef<jobject>& obj,
44 const base::android::JavaParamRef<jintArray>& jtile_types);
45 void RecordOpenedMostVisitedItem( 41 void RecordOpenedMostVisitedItem(
46 JNIEnv* env, 42 JNIEnv* env,
47 const base::android::JavaParamRef<jobject>& obj, 43 const base::android::JavaParamRef<jobject>& obj,
48 jint index, 44 jint index,
49 jint tile_type); 45 jint tile_type);
50 46
51 // Registers JNI methods. 47 // Registers JNI methods.
52 static bool Register(JNIEnv* env); 48 static bool Register(JNIEnv* env);
53 49
54 private: 50 private:
(...skipping 23 matching lines...) Expand all
78 register_observer_; 74 register_observer_;
79 }; 75 };
80 SupervisorBridge supervisor_; 76 SupervisorBridge supervisor_;
81 77
82 ntp_tiles::MostVisitedSites most_visited_; 78 ntp_tiles::MostVisitedSites most_visited_;
83 79
84 DISALLOW_COPY_AND_ASSIGN(MostVisitedSitesBridge); 80 DISALLOW_COPY_AND_ASSIGN(MostVisitedSitesBridge);
85 }; 81 };
86 82
87 #endif // CHROME_BROWSER_ANDROID_NTP_MOST_VISITED_SITES_BRIDGE_H_ 83 #endif // CHROME_BROWSER_ANDROID_NTP_MOST_VISITED_SITES_BRIDGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698