Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2105933002: NTP: Fix metrics recording crash by plumbing the necessary data to Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Even more fixes. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.ntp; 5 package org.chromium.chrome.browser.ntp;
6 6
7 import android.annotation.TargetApi; 7 import android.annotation.TargetApi;
8 import android.app.Activity; 8 import android.app.Activity;
9 import android.app.Dialog; 9 import android.app.Dialog;
10 import android.content.Context; 10 import android.content.Context;
(...skipping 510 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 long loadTimeMs = (System.nanoTime() - mConstructedTimeNs) / 1000000 ; 521 long loadTimeMs = (System.nanoTime() - mConstructedTimeNs) / 1000000 ;
522 RecordHistogram.recordTimesHistogram( 522 RecordHistogram.recordTimesHistogram(
523 "Tab.NewTabOnload", loadTimeMs, TimeUnit.MILLISECONDS); 523 "Tab.NewTabOnload", loadTimeMs, TimeUnit.MILLISECONDS);
524 mIsLoaded = true; 524 mIsLoaded = true;
525 StartupMetrics.getInstance().recordOpenedNTP(); 525 StartupMetrics.getInstance().recordOpenedNTP();
526 NewTabPageUma.recordNTPImpression(NewTabPageUma.NTP_IMPRESSION_REGUL AR); 526 NewTabPageUma.recordNTPImpression(NewTabPageUma.NTP_IMPRESSION_REGUL AR);
527 // If not visible when loading completes, wait until onShown is rece ived. 527 // If not visible when loading completes, wait until onShown is rece ived.
528 if (!mTab.isHidden()) recordNTPShown(); 528 if (!mTab.isHidden()) recordNTPShown();
529 529
530 int tileTypes[] = new int[items.length]; 530 int tileTypes[] = new int[items.length];
531 int sources[] = new int[items.length];
532 int providerIndices[] = new int[items.length];
533
531 for (int i = 0; i < items.length; i++) { 534 for (int i = 0; i < items.length; i++) {
532 tileTypes[i] = items[i].getTileType(); 535 tileTypes[i] = items[i].getTileType();
536 sources[i] = items[i].getSource();
537 providerIndices[i] = items[i].getProviderIndex();
533 } 538 }
534 mMostVisitedSites.recordTileTypeMetrics(tileTypes); 539
540 mMostVisitedSites.recordTileTypeMetrics(tileTypes, sources, provider Indices);
535 541
536 if (isNtpOfflinePagesEnabled()) { 542 if (isNtpOfflinePagesEnabled()) {
537 final int maxNumTiles = 12; 543 final int maxNumTiles = 12;
538 for (int i = 0; i < items.length; i++) { 544 for (int i = 0; i < items.length; i++) {
539 if (items[i].isOfflineAvailable()) { 545 if (items[i].isOfflineAvailable()) {
540 RecordHistogram.recordEnumeratedHistogram( 546 RecordHistogram.recordEnumeratedHistogram(
541 "NewTabPage.TileOfflineAvailable", i, maxNumTile s); 547 "NewTabPage.TileOfflineAvailable", i, maxNumTile s);
542 } 548 }
543 } 549 }
544 } 550 }
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
815 @Override 821 @Override
816 public boolean shouldCaptureThumbnail() { 822 public boolean shouldCaptureThumbnail() {
817 return mNewTabPageView.shouldCaptureThumbnail(); 823 return mNewTabPageView.shouldCaptureThumbnail();
818 } 824 }
819 825
820 @Override 826 @Override
821 public void captureThumbnail(Canvas canvas) { 827 public void captureThumbnail(Canvas canvas) {
822 mNewTabPageView.captureThumbnail(canvas); 828 mNewTabPageView.captureThumbnail(canvas);
823 } 829 }
824 } 830 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698