Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2105873002: Fix net/third_party/nss/README.chromium. (Closed)

Created:
4 years, 5 months ago by davidben
Modified:
4 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix net/third_party/nss/README.chromium. It refers to patches which are no longer valid. Also point to the LICENSE file now that there are no other copies to pick it up from. BUG=none Committed: https://crrev.com/9e1df26c5b72a94f27a46753830170ca3c44632f Cr-Commit-Position: refs/heads/master@{#402552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -61 lines) Patch
M net/third_party/nss/README.chromium View 1 chunk +2 lines, -61 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
davidben
4 years, 5 months ago (2016-06-28 17:46:54 UTC) #2
Ryan Sleevi
I'm not sure changing the license file is right. This is NOT_SHIPPED, is it not?
4 years, 5 months ago (2016-06-28 17:51:48 UTC) #3
davidben
On 2016/06/28 17:51:48, Ryan Sleevi wrote: > I'm not sure changing the license file is ...
4 years, 5 months ago (2016-06-28 17:57:28 UTC) #4
Ryan Sleevi
Oh right, this is the //net version LGTM
4 years, 5 months ago (2016-06-28 18:04:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105873002/1
4 years, 5 months ago (2016-06-28 18:12:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/253956)
4 years, 5 months ago (2016-06-28 19:51:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105873002/1
4 years, 5 months ago (2016-06-28 20:08:35 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 21:39:02 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 21:42:09 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e1df26c5b72a94f27a46753830170ca3c44632f
Cr-Commit-Position: refs/heads/master@{#402552}

Powered by Google App Engine
This is Rietveld 408576698