Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2105863005: Added/replaced icons in material design user menu (Closed)

Created:
4 years, 5 months ago by Jane
Modified:
4 years, 5 months ago
Reviewers:
*sky, *Evan Stade
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added/replaced icons in material design user menu Specifically: 1. Added account_circle.icon and used it for the guest profile button in the user menu 2. Added close_all.icon and used it for "Close all your windows" button in the user menu See mocks here: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu#%2Fspec-1.png BUG=615893 Committed: https://crrev.com/7a67c7464a9e96032efd3adff31226aae06507a8 Cr-Commit-Position: refs/heads/master@{#403071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -2 lines) Patch
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/account_circle.icon View 1 chunk +24 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/close_all.icon View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Jane
Thanks!
4 years, 5 months ago (2016-06-29 15:42:41 UTC) #7
sky
LGTM
4 years, 5 months ago (2016-06-29 21:01:18 UTC) #8
Evan Stade
lgtm
4 years, 5 months ago (2016-06-29 22:10:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105863005/1
4 years, 5 months ago (2016-06-30 01:22:05 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 02:22:15 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 02:22:26 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 02:23:29 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a67c7464a9e96032efd3adff31226aae06507a8
Cr-Commit-Position: refs/heads/master@{#403071}

Powered by Google App Engine
This is Rietveld 408576698