Verify that the notification response contains sensible data

chrome/browser/notifications/notification_platform_bridge_mac.h

Index: chrome/browser/notifications/notification_platform_bridge_mac.h
diff --git a/chrome/browser/notifications/notification_platform_bridge_mac.h b/chrome/browser/notifications/notification_platform_bridge_mac.h
index ad261aaa79764597f596b48b1d6b0472d580f005..8337672b2007e573f005dadb6753b6f4bc156b20 100644
--- a/chrome/browser/notifications/notification_platform_bridge_mac.h
+++ b/chrome/browser/notifications/notification_platform_bridge_mac.h
@@ -37,6 +37,12 @@ class NotificationPlatformBridgeMac : public NotificationPlatformBridge {
                     std::set<std::string>* notifications) const override;
   bool SupportsNotificationCenter() const override;
 
+  // Perform some sanity checks on the returned values. Since the notification
+  // data comes from outside of Chrome it's better to do real production checks
+  // than just DCHECKS.
+  // Returns true if all the checks pass, false otherwise.

[Peter Beverloo, 2016/06/28 23:35:52]

There is a contrast between "some sanity checks" and "real production checks".
How about generalizing as:

  // Validates contents of the |response| dictionary as received from the system
  // when a notification gets activated.

[Miguel Garcia, 2016/06/30 10:42:00]

Done.

+  static bool VerifyNotificationData(NSDictionary* response);

[Peter Beverloo, 2016/06/28 23:35:52]

Please annotate this with WARN_UNUSED_RESULT from compiler_specific.h since it's
security-sensitive.

[Miguel Garcia, 2016/06/30 10:42:00]

Done.

+
  private:
   // Cocoa class that receives callbacks from the NSUserNotificationCenter.
   base::scoped_nsobject<NotificationCenterDelegate> delegate_;