Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Side by Side Diff: chrome/browser/notifications/notification_platform_bridge_mac.h

Issue 2105863002: Verify that the notification response contains sensible data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_ 5 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_
6 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_ 6 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
11 #include "base/compiler_specific.h"
11 #include "base/mac/scoped_nsobject.h" 12 #include "base/mac/scoped_nsobject.h"
12 #include "base/macros.h" 13 #include "base/macros.h"
13 #include "chrome/browser/notifications/notification_platform_bridge.h" 14 #include "chrome/browser/notifications/notification_platform_bridge.h"
14 15
15 class Notification; 16 class Notification;
16 @class NotificationCenterDelegate; 17 @class NotificationCenterDelegate;
17 @class NSUserNotificationCenter; 18 @class NSUserNotificationCenter;
18 class PrefService; 19 class PrefService;
19 20
20 // This class is an implementation of NotificationPlatformBridge that will 21 // This class is an implementation of NotificationPlatformBridge that will
21 // send platform notifications to the the MacOSX notification center. 22 // send platform notifications to the the MacOSX notification center.
22 class NotificationPlatformBridgeMac : public NotificationPlatformBridge { 23 class NotificationPlatformBridgeMac : public NotificationPlatformBridge {
23 public: 24 public:
24 explicit NotificationPlatformBridgeMac( 25 explicit NotificationPlatformBridgeMac(
25 NSUserNotificationCenter* notification_center); 26 NSUserNotificationCenter* notification_center);
26 ~NotificationPlatformBridgeMac() override; 27 ~NotificationPlatformBridgeMac() override;
27 28
28 // NotificationPlatformBridge implementation. 29 // NotificationPlatformBridge implementation.
29 void Display(const std::string& notification_id, 30 void Display(const std::string& notification_id,
30 const std::string& profile_id, 31 const std::string& profile_id,
31 bool incognito, 32 bool incognito,
32 const Notification& notification) override; 33 const Notification& notification) override;
33 void Close(const std::string& profile_id, 34 void Close(const std::string& profile_id,
34 const std::string& notification_id) override; 35 const std::string& notification_id) override;
35 bool GetDisplayed(const std::string& profile_id, 36 bool GetDisplayed(const std::string& profile_id,
36 bool incognito, 37 bool incognito,
37 std::set<std::string>* notifications) const override; 38 std::set<std::string>* notifications) const override;
38 bool SupportsNotificationCenter() const override; 39 bool SupportsNotificationCenter() const override;
39 40
41 // Validates contents of the |response| dictionary as received from the system
42 // when a notification gets activated.
43 static bool VerifyNotificationData(NSDictionary* response) WARN_UNUSED_RESULT;
44
40 private: 45 private:
41 // Cocoa class that receives callbacks from the NSUserNotificationCenter. 46 // Cocoa class that receives callbacks from the NSUserNotificationCenter.
42 base::scoped_nsobject<NotificationCenterDelegate> delegate_; 47 base::scoped_nsobject<NotificationCenterDelegate> delegate_;
43 48
44 // The notification center to use, this can be overriden in tests 49 // The notification center to use, this can be overriden in tests
45 NSUserNotificationCenter* notification_center_; 50 NSUserNotificationCenter* notification_center_;
46 51
47 DISALLOW_COPY_AND_ASSIGN(NotificationPlatformBridgeMac); 52 DISALLOW_COPY_AND_ASSIGN(NotificationPlatformBridgeMac);
48 }; 53 };
49 54
50 #endif // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_ 55 #endif // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698