[MD settings] side nav ink ripple on click

chrome/browser/resources/settings/settings_menu/settings_menu.js

Index: chrome/browser/resources/settings/settings_menu/settings_menu.js
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js
index d2a4c90547977df353e16b76a8f876d4c5389822..3d13026061e03d92efb6ffe350ecef6c1b13447b 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js
@@ -63,10 +63,25 @@ Polymer({
   },
 
   /**
+   * @param {!Node} target
+   * @private
+   */
+  ripple_: function(target) {
+    var ripple = document.createElement('paper-ripple');
+    ripple.addEventListener('transitionend', function() {
+      Polymer.dom(target).removeChild(ripple);

[michaelpg, 2016/07/06 23:19:06]

ripple.remove();

[Dan Beam, 2016/07/06 23:24:26]

+1

[dschuyler, 2016/07/07 01:36:09]

Done.

[dschuyler, 2016/07/07 01:36:09]

Done.

+    });
+    Polymer.dom(target).appendChild(ripple);

[Dan Beam, 2016/07/06 23:24:26]

why are you Polymer.dom()'ing |target|?

[dschuyler, 2016/07/07 01:36:09]

Mistakenly thought that was correct.

Done.

+    ripple.downAction();
+    ripple.upAction();
+  },
+
+  /**
    * @param {!Event} event
    * @private
    */
   openPage_: function(event) {
+    this.ripple_(/** @type {!Node} */(event.currentTarget));
     var submenuRoute = event.currentTarget.parentNode.dataset.page;
     if (submenuRoute) {
       this.currentRoute = {