Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8520)

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.js

Issue 2105833003: [MD settings] side nav ink ripple on click (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_menu/settings_menu.js
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js
index d2a4c90547977df353e16b76a8f876d4c5389822..bf08e537f9a7f6b966ed7f97f1dbe9de9ff99a6b 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js
@@ -66,7 +66,19 @@ Polymer({
* @param {!Event} event
Dan Beam 2016/06/28 23:59:43 this should be target
dschuyler 2016/07/06 21:05:33 Done.
* @private
*/
+ ripple_: function(target) {
+ var ripple = document.createElement('paper-ripple');
+ ripple.addEventListener('transitionend', function() {
+ Polymer.dom(target).removeChild(ripple);
+ });
+ Polymer.dom(target).appendChild(ripple);
+ ripple.downAction();
+ ripple.upAction();
+ },
+
+ /** @private */
openPage_: function(event) {
Dan Beam 2016/06/28 23:59:43 document |event|
dschuyler 2016/07/06 21:05:33 Done.
+ this.ripple_(event.currentTarget);
var submenuRoute = event.currentTarget.parentNode.dataset.page;
if (submenuRoute) {
this.currentRoute = {

Powered by Google App Engine
This is Rietveld 408576698