Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: ui/app_list/views/app_list_folder_view.h

Issue 210583004: Make cancelling of app list correctly clean up folder UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/app_list/views/app_list_folder_view.h
diff --git a/ui/app_list/views/app_list_folder_view.h b/ui/app_list/views/app_list_folder_view.h
index b58d5e4ee6a67ff88a9e5136f0c35d53e76be629..c9645acfd0079d6fc2b06bd2ca09f89c81802495 100644
--- a/ui/app_list/views/app_list_folder_view.h
+++ b/ui/app_list/views/app_list_folder_view.h
@@ -7,6 +7,7 @@
#include "ui/app_list/app_list_item_list_observer.h"
#include "ui/app_list/views/apps_grid_view.h"
+#include "ui/app_list/views/apps_grid_view_folder_delegate.h"
#include "ui/app_list/views/folder_header_view.h"
#include "ui/app_list/views/folder_header_view_delegate.h"
#include "ui/compositor/layer_animation_observer.h"
@@ -35,7 +36,8 @@ class PaginationModel;
class AppListFolderView : public views::View,
public FolderHeaderViewDelegate,
public AppListItemListObserver,
- public ui::ImplicitAnimationObserver {
+ public ui::ImplicitAnimationObserver,
+ public AppsGridViewFolderDelegate {
public:
AppListFolderView(AppsContainerView* container_view,
AppListModel* model,
@@ -54,33 +56,8 @@ class AppListFolderView : public views::View,
// AppListFolderView.
gfx::Rect GetItemIconBoundsAt(int index);
- // Updates the folder view background to show or hide folder container ink
- // bubble.
- void UpdateFolderViewBackground(bool show_bubble);
-
void UpdateFolderNameVisibility(bool visible);
- // Returns true if |point| falls outside of the folder container ink bubble.
- bool IsPointOutsideOfFolderBoundray(const gfx::Point& point);
-
- // Called when a folder item is dragged out of the folder to be re-parented.
- // |original_drag_view| is the |drag_view_| inside the folder's grid view.
- // |drag_point_in_folder_grid| is the last drag point in coordinate of the
- // AppsGridView inside the folder.
- void ReparentItem(AppListItemView* original_drag_view,
- const gfx::Point& drag_point_in_folder_grid);
-
- // Dispatches drag event from the hidden grid view to the root level grid view
- // for re-parenting a folder item.
- void DispatchDragEventForReparent(AppsGridView::Pointer pointer,
- const ui::LocatedEvent& event);
-
- // Dispatches EndDrag event from the hidden grid view to the root level grid
- // view for reparenting a folder item.
- // |events_forwarded_to_drag_drop_host|: True if the dragged item is dropped
- // to the drag_drop_host, eg. dropped on shelf.
- void DispatchEndDragEventForReparent(bool events_forwarded_to_drag_drop_host);
-
// Hides the view immediately without animation.
void HideViewImmediately();
@@ -114,6 +91,18 @@ class AppListFolderView : public views::View,
virtual void SetItemName(AppListFolderItem* item,
const std::string& name) OVERRIDE;
+ // Overridden from AppsGridViewFolderDelegate:
+ virtual void UpdateFolderViewBackground(bool show_bubble) OVERRIDE;
+ virtual void ReparentItem(AppListItemView* original_drag_view,
+ const gfx::Point& drag_point_in_folder_grid)
+ OVERRIDE;
tapted 2014/03/26 02:53:54 nit: I think "OVERRIDE" isn't meant to appear on a
jennyz 2014/03/26 22:09:38 +1, having OVERRIDE on a separate line looks a lit
calamity 2014/03/27 05:14:44 clang-format =(
+ virtual void DispatchDragEventForReparent(AppsGridView::Pointer pointer,
+ const ui::LocatedEvent& event)
+ OVERRIDE;
+ virtual void DispatchEndDragEventForReparent(
+ bool events_forwarded_to_drag_drop_host) OVERRIDE;
+ virtual bool IsPointOutsideOfFolderBoundary(const gfx::Point& point) OVERRIDE;
+
AppsContainerView* container_view_; // Not owned.
AppListMainView* app_list_main_view_; // Not Owned.
FolderHeaderView* folder_header_view_; // Owned by views hierarchy.

Powered by Google App Engine
This is Rietveld 408576698