Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Side by Side Diff: src/code-stubs-hydrogen.cc

Issue 21058003: Store mode for keyed stores should be passed in from type feedback (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Quick punctuation fix Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after
488 488
489 489
490 Handle<Code> CreateAllocationSiteStub::GenerateCode() { 490 Handle<Code> CreateAllocationSiteStub::GenerateCode() {
491 return DoGenerateCode(this); 491 return DoGenerateCode(this);
492 } 492 }
493 493
494 494
495 template <> 495 template <>
496 HValue* CodeStubGraphBuilder<KeyedLoadFastElementStub>::BuildCodeStub() { 496 HValue* CodeStubGraphBuilder<KeyedLoadFastElementStub>::BuildCodeStub() {
497 HInstruction* load = BuildUncheckedMonomorphicElementAccess( 497 HInstruction* load = BuildUncheckedMonomorphicElementAccess(
498 GetParameter(0), GetParameter(1), NULL, NULL, 498 GetParameter(0), GetParameter(1), NULL,
499 casted_stub()->is_js_array(), casted_stub()->elements_kind(), 499 casted_stub()->is_js_array(), casted_stub()->elements_kind(),
500 false, NEVER_RETURN_HOLE, STANDARD_STORE); 500 false, NEVER_RETURN_HOLE, STANDARD_STORE);
501 return load; 501 return load;
502 } 502 }
503 503
504 504
505 Handle<Code> KeyedLoadFastElementStub::GenerateCode() { 505 Handle<Code> KeyedLoadFastElementStub::GenerateCode() {
506 return DoGenerateCode(this); 506 return DoGenerateCode(this);
507 } 507 }
508 508
(...skipping 24 matching lines...) Expand all
533 533
534 534
535 Handle<Code> KeyedLoadFieldStub::GenerateCode() { 535 Handle<Code> KeyedLoadFieldStub::GenerateCode() {
536 return DoGenerateCode(this); 536 return DoGenerateCode(this);
537 } 537 }
538 538
539 539
540 template <> 540 template <>
541 HValue* CodeStubGraphBuilder<KeyedStoreFastElementStub>::BuildCodeStub() { 541 HValue* CodeStubGraphBuilder<KeyedStoreFastElementStub>::BuildCodeStub() {
542 BuildUncheckedMonomorphicElementAccess( 542 BuildUncheckedMonomorphicElementAccess(
543 GetParameter(0), GetParameter(1), GetParameter(2), NULL, 543 GetParameter(0), GetParameter(1), GetParameter(2),
544 casted_stub()->is_js_array(), casted_stub()->elements_kind(), 544 casted_stub()->is_js_array(), casted_stub()->elements_kind(),
545 true, NEVER_RETURN_HOLE, casted_stub()->store_mode()); 545 true, NEVER_RETURN_HOLE, casted_stub()->store_mode());
546 546
547 return GetParameter(2); 547 return GetParameter(2);
548 } 548 }
549 549
550 550
551 Handle<Code> KeyedStoreFastElementStub::GenerateCode() { 551 Handle<Code> KeyedStoreFastElementStub::GenerateCode() {
552 return DoGenerateCode(this); 552 return DoGenerateCode(this);
553 } 553 }
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
881 Add<HDeoptimize>("Deopt due to --trace-elements-transitions", 881 Add<HDeoptimize>("Deopt due to --trace-elements-transitions",
882 Deoptimizer::EAGER); 882 Deoptimizer::EAGER);
883 } else { 883 } else {
884 info()->MarkAsSavesCallerDoubles(); 884 info()->MarkAsSavesCallerDoubles();
885 885
886 BuildTransitionElementsKind(object, map, 886 BuildTransitionElementsKind(object, map,
887 casted_stub()->from_kind(), 887 casted_stub()->from_kind(),
888 casted_stub()->to_kind(), 888 casted_stub()->to_kind(),
889 casted_stub()->is_jsarray()); 889 casted_stub()->is_jsarray());
890 890
891 BuildUncheckedMonomorphicElementAccess(object, key, value, NULL, 891 BuildUncheckedMonomorphicElementAccess(object, key, value,
892 casted_stub()->is_jsarray(), 892 casted_stub()->is_jsarray(),
893 casted_stub()->to_kind(), 893 casted_stub()->to_kind(),
894 true, ALLOW_RETURN_HOLE, 894 true, ALLOW_RETURN_HOLE,
895 casted_stub()->store_mode()); 895 casted_stub()->store_mode());
896 } 896 }
897 897
898 return value; 898 return value;
899 } 899 }
900 900
901 901
902 Handle<Code> ElementsTransitionAndStoreStub::GenerateCode() { 902 Handle<Code> ElementsTransitionAndStoreStub::GenerateCode() {
903 return DoGenerateCode(this); 903 return DoGenerateCode(this);
904 } 904 }
905 905
906 906
907 } } // namespace v8::internal 907 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698