Suppress timeouts on Windows browser bots when dart2js hangs.

Suppress timeouts on Windows browser bots when dart2js hangs.

Also run dartfmt on test_runner.dart file.

BUG=https://github.com/dart-lang/sdk/issues/26060
R=sgjesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/f3c5ec9ff1cb93a88f4ee1accfaefb75e39f6af1

[Søren Gjesse, 2016-06-28 14:40:08]

https://codereview.chromium.org/2105783002/diff/1/tools/testing/dart/test_run...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/2105783002/diff/1/tools/testing/dart/test_run...
tools/testing/dart/test_runner.dart:1576: return (isWindows &&
isBrowserTestCase)
Don't you want to count the number of ignores, so that if something is causing a
lot of timeouts the bot will still fail?

Also the case of a single browser test that times out will now be masked on
Windows.

[Bill Hesse, 2016-06-28 14:45:59]

https://codereview.chromium.org/2105783002/diff/1/tools/testing/dart/test_run...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/2105783002/diff/1/tools/testing/dart/test_run...
tools/testing/dart/test_runner.dart:1576: return (isWindows &&
isBrowserTestCase)
On 2016/06/28 14:40:08, Søren Gjesse wrote:
> Don't you want to count the number of ignores, so that if something is causing
a
> lot of timeouts the bot will still fail?
> 
> Also the case of a single browser test that times out will now be masked on
> Windows.

The number of ignores is counted at a higher level, when it is reported to a
progress monitor as the output status of this test case.  If there are more than
5 of them in a run, then the run fails.


It is only the dart2js compilation timing out, that falls in this case.  We can
create a Windows bot that only does dart2js compilation, and then the timeout
will be reported, since it will not be a browser test case.  I think we have
other dart2js bots that are slower than this, on non-windows platforms, so it is
unlikely it won't trigger them first.

[Søren Gjesse, 2016-06-28 15:12:19]

lgtm

https://codereview.chromium.org/2105783002/diff/1/tools/testing/dart/test_run...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/2105783002/diff/1/tools/testing/dart/test_run...
tools/testing/dart/test_runner.dart:1576: return (isWindows &&
isBrowserTestCase)
On 2016/06/28 14:45:59, Bill Hesse wrote:
> On 2016/06/28 14:40:08, Søren Gjesse wrote:
> > Don't you want to count the number of ignores, so that if something is
causing
> a
> > lot of timeouts the bot will still fail?
> > 
> > Also the case of a single browser test that times out will now be masked on
> > Windows.
> 
> The number of ignores is counted at a higher level, when it is reported to a
> progress monitor as the output status of this test case.  If there are more
than
> 5 of them in a run, then the run fails.
> 
> 
> It is only the dart2js compilation timing out, that falls in this case.  We
can
> create a Windows bot that only does dart2js compilation, and then the timeout
> will be reported, since it will not be a browser test case.  I think we have
> other dart2js bots that are slower than this, on non-windows platforms, so it
is
> unlikely it won't trigger them first.

Thanks for the clarification.

[Bill Hesse, 2016-06-28 15:23:09]

Description was changed from

==========
Suppress timeouts on Windows browser bots when dart2js hangs.

Also run dartfmt on test_runner.dart file.

BUG=https://github.com/dart-lang/sdk/issues/26060
R=sgjesse@google.com
==========

to

==========
Suppress timeouts on Windows browser bots when dart2js hangs.

Also run dartfmt on test_runner.dart file.

BUG=https://github.com/dart-lang/sdk/issues/26060
R=sgjesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f3c5ec9ff1cb93a88f4ee1accfaefb75e39f6af1
==========

[Bill Hesse, 2016-06-28 15:23:11]

Committed patchset #1 (id:1) manually as
f3c5ec9ff1cb93a88f4ee1accfaefb75e39f6af1 (presubmit successful).