Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2105763002: Adds WTF::debug::ScopedCrashKey as an alias of base::debug::ScopedCrashKey. (Closed)

Created:
4 years, 5 months ago by Yuki
Modified:
4 years, 5 months ago
Reviewers:
haraken, dcheng
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds WTF::debug::ScopedCrashKey as an alias of base::debug::ScopedCrashKey. Allows Blink to use base::debug::ScopedCrashKey. BUG=621730 Committed: https://crrev.com/28dd2edf07c976d50601e5690dd24485f38c1ed6 Cr-Commit-Position: refs/heads/master@{#402602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
A third_party/WebKit/Source/wtf/debug/CrashLogging.h View 1 chunk +19 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/wtf/debug/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/wtf.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yuki
Just in case, I made a separate CL that only introduce WTF::debug::ScopedCrashKey, so that we ...
4 years, 5 months ago (2016-06-28 12:22:34 UTC) #2
haraken
LGTM I'm not sure if we want to create a directory for one file, but ...
4 years, 5 months ago (2016-06-28 14:54:37 UTC) #3
dcheng
//base DEP LGTM
4 years, 5 months ago (2016-06-28 15:26:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105763002/1
4 years, 5 months ago (2016-06-28 23:08:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 23:53:52 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 23:55:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28dd2edf07c976d50601e5690dd24485f38c1ed6
Cr-Commit-Position: refs/heads/master@{#402602}

Powered by Google App Engine
This is Rietveld 408576698