Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2105743003:
Remove unused iOS network error strings (Closed)
|
Created:
4 years, 5 months ago by edwardjung Modified:
4 years, 5 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove unused iOS network error strings
BUG=620113
Committed: https://crrev.com/2b8c4b47acfae1445908f0fec62c217e25b53c48
Cr-Commit-Position: refs/heads/master@{#403145}
Patch Set 1 #
Messages
Total messages: 18 (7 generated)
edwardjung@chromium.org changed reviewers: + mmenke@chromium.org, sdefresne@chromium.org
@sdefresne, separated the removal of these iOS network error strings. Please double check. mmenke for approval. Thanks.
On 2016/06/28 14:13:42, edwardjung wrote: > @sdefresne, separated the removal of these iOS network error strings. Please > double check. > > mmenke for approval. > > Thanks. LGTM!
lgtm
The CQ bit was checked by edwardjung@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by edwardjung@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by edwardjung@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Remove unused iOS network error strings BUG=620113 ========== to ========== Remove unused iOS network error strings BUG=620113 Committed: https://crrev.com/2b8c4b47acfae1445908f0fec62c217e25b53c48 Cr-Commit-Position: refs/heads/master@{#403145} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2b8c4b47acfae1445908f0fec62c217e25b53c48 Cr-Commit-Position: refs/heads/master@{#403145} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
