third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp - Issue 2105743002: Optimize style recalc when adding @keyframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

Issue 2105743002: Optimize style recalc when adding @keyframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test review issues Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

index 58abde39e0139fbef8d75db520e6ac09c5d213d4..e8527a843ad0a47a2fbb619a4aa42543b3d45db2 100644

--- a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

@@ -295,8 +295,10 @@ void CSSAnimations::calculateAnimationUpdate(CSSAnimationUpdate& update, const E

timing.timingFunction = Timing::defaults().timingFunction;

StyleRuleKeyframes* keyframesRule = resolver->findKeyframesRule(elementForScoping, name);

- if (!keyframesRule)

+ if (!keyframesRule) {

+ element.document().styleEngine().setHasUnresolvedKeyframesRule();

continue; // Cancel the animation if there's no style rule for it.

+ }

const RunningAnimation* existingAnimation = nullptr;

size_t existingAnimationIndex = 0;