third_party/WebKit/Source/core/animation/Animation.cpp - Issue 2105743002: Optimize style recalc when adding @keyframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/Animation.cpp

Issue 2105743002: Optimize style recalc when adding @keyframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test review issues Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/Animation.h ('k') | third_party/WebKit/Source/core/animation/AnimationTimeline.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/Animation.cpp

diff --git a/third_party/WebKit/Source/core/animation/Animation.cpp b/third_party/WebKit/Source/core/animation/Animation.cpp

index 9cd519a2ba74efde365c05016741d943b2612823..9326e67f168bc0550e650f9c0b0be692004b49e1 100644

--- a/third_party/WebKit/Source/core/animation/Animation.cpp

+++ b/third_party/WebKit/Source/core/animation/Animation.cpp

@@ -35,6 +35,7 @@

#include "core/animation/KeyframeEffect.h"

#include "core/dom/Document.h"

#include "core/dom/ExceptionCode.h"

+#include "core/dom/StyleChangeReason.h"

#include "core/events/AnimationPlayerEvent.h"

#include "core/frame/UseCounter.h"

#include "core/inspector/InspectorInstrumentation.h"

@@ -1079,6 +1080,14 @@ void Animation::disableCompositedAnimationForTesting()

cancelAnimationOnCompositor();

}

+void Animation::invalidateKeyframeEffect()

+ if (!m_content || !m_content->isKeyframeEffect())

+ return;

+ toKeyframeEffect(m_content.get())->target()->setNeedsStyleRecalc(LocalStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::StyleSheetChange));

DEFINE_TRACE(Animation)

{

visitor->trace(m_content);