Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 210573002: Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits (Closed)

Created:
6 years, 9 months ago by eae
Modified:
6 years, 9 months ago
Reviewers:
pdr., dglazkov
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits Remove the unused m_emSizeInFontUnits field and emSizeInFontUnits method from FontPlatformDataHarfBuzz. BUG=355806 R=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M Source/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.cpp View 8 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
eae
6 years, 9 months ago (2014-03-25 00:04:24 UTC) #1
eae
6 years, 9 months ago (2014-03-25 14:55:43 UTC) #2
dglazkov
lgtm
6 years, 9 months ago (2014-03-25 16:07:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/210573002/1
6 years, 9 months ago (2014-03-25 16:07:22 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 16:10:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-25 16:10:33 UTC) #6
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-25 16:11:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/210573002/1
6 years, 9 months ago (2014-03-25 16:11:42 UTC) #8
commit-bot: I haz the power
Change committed as 169955
6 years, 9 months ago (2014-03-25 16:24:46 UTC) #9
vsevik
A revert of this CL has been created in https://codereview.chromium.org/212763002/ by vsevik@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-26 12:10:35 UTC) #10
vsevik
6 years, 9 months ago (2014-03-26 12:23:12 UTC) #11
Message was sent while issue was closed.
On 2014/03/26 12:10:35, vsevik wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/212763002/ by mailto:vsevik@chromium.org.
> 
> The reason for reverting is: This might have caused android tests failure: 
>
http://build.chromium.org/p/chromium.webkit/builders/Android%2520Tests%2520%2...
> Speculatively reverting it..

I don't think this was actually a reason, so I reverted the revert.

Powered by Google App Engine
This is Rietveld 408576698