Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Unified Diff: third_party/WebKit/public/platform/WebURLLoaderClient.h

Issue 2105713002: Render process changes for ResourceTiming sizes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@resource_timing_sizes_browser_process
Patch Set: Fixes from ksakamoto review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebURLLoaderClient.h
diff --git a/third_party/WebKit/public/platform/WebURLLoaderClient.h b/third_party/WebKit/public/platform/WebURLLoaderClient.h
index 41b7bee7db94cf0f07c1b382f38b047b64651e6c..a74e9c5216a8ccc4e0c3ba321fe02e7be3c790fb 100644
--- a/third_party/WebKit/public/platform/WebURLLoaderClient.h
+++ b/third_party/WebKit/public/platform/WebURLLoaderClient.h
@@ -46,7 +46,7 @@ public:
// Called when following a redirect. |newRequest| contains the request
// generated by the redirect. The client may modify |newRequest|.
kinuko 2016/07/04 04:08:12 could we update the comment?
Adam Rice 2016/07/04 06:33:42 Done.
virtual void willFollowRedirect(
- WebURLLoader*, WebURLRequest& newRequest, const WebURLResponse& redirectResponse) { }
+ WebURLLoader*, WebURLRequest& newRequest, const WebURLResponse& redirectResponse, int64_t encodedDataLength) {}
// Called to report upload progress. The bytes reported correspond to
// the HTTP message body.
@@ -69,7 +69,7 @@ public:
virtual void didDownloadData(WebURLLoader*, int dataLength, int encodedDataLength) { }
// Called when a chunk of response data is received.
kinuko 2016/07/04 04:08:12 Ditto. Also: similar to other comments, we seem t
Adam Rice 2016/07/04 06:33:42 I have documented this method as taking -1 when th
- virtual void didReceiveData(WebURLLoader*, const char* data, int dataLength, int encodedDataLength) { }
+ virtual void didReceiveData(WebURLLoader*, const char* data, int dataLength, int encodedDataLength, int encodedBodyLength) {}
// Called when a chunk of renderer-generated metadata is received from the cache.
virtual void didReceiveCachedMetadata(WebURLLoader*, const char* data, int dataLength) { }

Powered by Google App Engine
This is Rietveld 408576698