third_party/WebKit/Source/web/AssociatedURLLoader.cpp - Issue 2105713002: Render process changes for ResourceTiming sizes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/AssociatedURLLoader.cpp

Issue 2105713002: Render process changes for ResourceTiming sizes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@resource_timing_sizes_browser_process

Patch Set: Fix lint error: ASSERT -> DCHECK Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/network/ResourceTimingInfo.cpp ('K') | « third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc ('k') | third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/AssociatedURLLoader.cpp

diff --git a/third_party/WebKit/Source/web/AssociatedURLLoader.cpp b/third_party/WebKit/Source/web/AssociatedURLLoader.cpp

index a740f026f7a04fa89997ad82c336fe348033104c..9d0c68a123fa3d0cf5047b2f10065c3954b21729 100644

--- a/third_party/WebKit/Source/web/AssociatedURLLoader.cpp

+++ b/third_party/WebKit/Source/web/AssociatedURLLoader.cpp

@@ -149,7 +149,8 @@ void AssociatedURLLoader::ClientAdapter::willFollowRedirect(ResourceRequest& new

WrappedResourceRequest wrappedNewRequest(newRequest);

WrappedResourceResponse wrappedRedirectResponse(redirectResponse);

- m_client->willFollowRedirect(m_loader, wrappedNewRequest, wrappedRedirectResponse);

+ // FIXME: Set encodedDataLength

Kunihiko Sakamoto 2016/07/01 10:12:35 I believe TODO(someone) is now preferred over FIXM

Adam Rice 2016/07/04 02:44:18 Done.

+ m_client->willFollowRedirect(m_loader, wrappedNewRequest, wrappedRedirectResponse, 0);

}

void AssociatedURLLoader::ClientAdapter::didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent)

@@ -208,7 +209,7 @@ void AssociatedURLLoader::ClientAdapter::didReceiveData(const char* data, unsign

CHECK_LE(dataLength, static_cast<unsigned>(std::numeric_limits<int>::max()));

- m_client->didReceiveData(m_loader, data, dataLength, -1);

+ m_client->didReceiveData(m_loader, data, dataLength, -1, dataLength);

}

void AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata(const char* data, int dataLength)