media/blink/multibuffer_data_source_unittest.cc - Issue 2105713002: Render process changes for ResourceTiming sizes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/multibuffer_data_source_unittest.cc

Issue 2105713002: Render process changes for ResourceTiming sizes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@resource_timing_sizes_browser_process

Patch Set: Fix lint error: ASSERT -> DCHECK Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/extensions/extension_localization_peer.cc ('K') | « media/blink/buffered_resource_loader_unittest.cc ('k') | media/blink/resource_multibuffer_data_provider.h » ('j') | third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/blink/multibuffer_data_source_unittest.cc

diff --git a/media/blink/multibuffer_data_source_unittest.cc b/media/blink/multibuffer_data_source_unittest.cc

index 499c3c8217d6024be461da9260f72823bc24bfc5..2c043c29e6b29c7c667beb46cead373b56f54540 100644

--- a/media/blink/multibuffer_data_source_unittest.cc

+++ b/media/blink/multibuffer_data_source_unittest.cc

@@ -1345,7 +1345,7 @@ TEST_F(MultibufferDataSourceTest, Http_RetryThenRedirect) {

blink::WebURLRequest request((GURL(kHttpDifferentPathUrl)));

blink::WebURLResponse response((GURL(kHttpUrl)));

response.setHTTPStatusCode(307);

- data_provider()->willFollowRedirect(url_loader(), request, response);

+ data_provider()->willFollowRedirect(url_loader(), request, response, 0);

Respond(response_generator_->Generate206(kDataSize));

ReceiveData(kDataSize);

EXPECT_CALL(host_, AddBufferedByteRange(0, kDataSize * 3));

@@ -1361,7 +1361,7 @@ TEST_F(MultibufferDataSourceTest, Http_NotStreamingAfterRedirect) {

blink::WebURLRequest request((GURL(kHttpDifferentPathUrl)));

blink::WebURLResponse response((GURL(kHttpUrl)));

response.setHTTPStatusCode(307);

- data_provider()->willFollowRedirect(url_loader(), request, response);

+ data_provider()->willFollowRedirect(url_loader(), request, response, 0);

EXPECT_CALL(host_, SetTotalBytes(response_generator_->content_length()));

Respond(response_generator_->Generate206(0));