chrome/renderer/extensions/extension_localization_peer.cc - Issue 2105713002: Render process changes for ResourceTiming sizes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/extension_localization_peer.cc

Issue 2105713002: Render process changes for ResourceTiming sizes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@resource_timing_sizes_browser_process

Patch Set: Fix lint error: ASSERT -> DCHECK Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/extensions/extension_localization_peer.cc

diff --git a/chrome/renderer/extensions/extension_localization_peer.cc b/chrome/renderer/extensions/extension_localization_peer.cc

index 87b623ca4c0588b7a9750485555843b4763ea399..0c8bd432535a145fa4c5ce8780a13ac144939004 100644

--- a/chrome/renderer/extensions/extension_localization_peer.cc

+++ b/chrome/renderer/extensions/extension_localization_peer.cc

@@ -28,6 +28,9 @@ class StringData final : public content::RequestPeer::ReceivedData {

const char* payload() const override { return data_.data(); }

int length() const override { return data_.size(); }

int encoded_length() const override { return -1; }

Kunihiko Sakamoto 2016/07/01 10:12:35 encoded_data_length?

Adam Rice 2016/07/04 02:44:18 Done. Sorry for making you act as a human compiler

+ // The original data has substitutions applied, so the original

+ // encoded_body_length no longer applies.

+ int encoded_body_length() const override { return data.size(); }

Kunihiko Sakamoto 2016/07/01 10:12:35 s/data/data_/

Adam Rice 2016/07/04 02:44:18 Done.

private:

std::string data_;

« no previous file with comments | « no previous file | content/child/ftp_directory_listing_response_delegate.cc » ('j') | third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp » ('J')