third_party/WebKit/Source/platform/network/ResourceTimingInfo.cpp - Issue 2105713002: Render process changes for ResourceTiming sizes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/network/ResourceTimingInfo.cpp

Issue 2105713002: Render process changes for ResourceTiming sizes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@resource_timing_sizes_browser_process

Patch Set: Fixes from kinuko initial comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/timing/PerformanceResourceTiming.idl ('K') | « third_party/WebKit/Source/platform/network/ResourceTimingInfo.h ('k') | third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/network/ResourceTimingInfo.cpp

diff --git a/third_party/WebKit/Source/platform/network/ResourceTimingInfo.cpp b/third_party/WebKit/Source/platform/network/ResourceTimingInfo.cpp

index 064cc455f53795a771dfdc95e4f23990251388f5..61045e05536e4d0aade99c4389e3d875e7de1c22 100644

--- a/third_party/WebKit/Source/platform/network/ResourceTimingInfo.cpp

+++ b/third_party/WebKit/Source/platform/network/ResourceTimingInfo.cpp

@@ -33,8 +33,21 @@ std::unique_ptr<CrossThreadResourceTimingInfoData> ResourceTimingInfo::copyData(

data->m_finalResponse = m_finalResponse.copyData();

for (const auto& response : m_redirectChain)

data->m_redirectChain.append(response.copyData());

+ data->m_transferSize = m_transferSize;

data->m_isMainResource = m_isMainResource;

return data;

}

+void ResourceTimingInfo::addRedirect(const ResourceResponse& redirectResponse, long long encodedDataLength, bool crossOrigin)

+ m_redirectChain.append(redirectResponse);

+ if (crossOrigin && !m_hasCrossOriginRedirect) {

+ m_hasCrossOriginRedirect = true;

+ m_transferSize = 0;

+ } else if (!crossOrigin) {

+ DCHECK_GE(encodedDataLength, 0);

+ m_transferSize += encodedDataLength;

+ }

} // namespace blink