third_party/WebKit/Source/core/timing/PerformanceResourceTiming.idl - Issue 2105713002: Render process changes for ResourceTiming sizes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceResourceTiming.idl

Issue 2105713002: Render process changes for ResourceTiming sizes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@resource_timing_sizes_browser_process

Patch Set: Fixes from kinuko initial comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp ('k') | third_party/WebKit/Source/platform/exported/WebURLLoaderTestDelegate.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/timing/PerformanceResourceTiming.idl

diff --git a/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.idl b/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.idl

index 3dfd18eee3651c9f3de2664f534edea8c9473ed6..0940ee4d5116a121bea1462077f03594d33717c6 100644

--- a/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.idl

+++ b/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.idl

@@ -46,10 +46,9 @@ interface PerformanceResourceTiming : PerformanceEntry {

readonly attribute DOMHighResTimeStamp requestStart;

readonly attribute DOMHighResTimeStamp responseStart;

readonly attribute DOMHighResTimeStamp responseEnd;

- // TODO(foolip): The spec has tranferSize/encodedBodySize/decodedBodySize

- // and a serializer:

- // readonly attribute unsigned short transferSize;

- // readonly attribute unsigned short encodedBodySize;

- // readonly attribute unsigned short decodedBodySize;

+ readonly attribute unsigned short transferSize;

Kunihiko Sakamoto 2016/06/30 10:19:49 The spec says these fields are unsigned long long.

Adam Rice 2016/06/30 10:29:58 Wow. I don't know how I managed to get that wrong.

+ readonly attribute unsigned short encodedBodySize;

+ readonly attribute unsigned short decodedBodySize;

+ // TODO(foolip): The spec has a serializer:

// serializer = {inherit, attribute};

};