Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1417)

Unified Diff: content/child/web_url_loader_impl_unittest.cc

Issue 2105713002: Render process changes for ResourceTiming sizes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@resource_timing_sizes_browser_process
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/web_url_loader_impl_unittest.cc
diff --git a/content/child/web_url_loader_impl_unittest.cc b/content/child/web_url_loader_impl_unittest.cc
index 5284b1de5376cd2c72e12a327afc707c1db7bba8..fbbb4e4dbbe750d902896e7d70944524819109a1 100644
--- a/content/child/web_url_loader_impl_unittest.cc
+++ b/content/child/web_url_loader_impl_unittest.cc
@@ -124,10 +124,10 @@ class TestWebURLLoaderClient : public blink::WebURLLoaderClient {
~TestWebURLLoaderClient() override {}
// blink::WebURLLoaderClient implementation:
- void willFollowRedirect(
- blink::WebURLLoader* loader,
- blink::WebURLRequest& newRequest,
- const blink::WebURLResponse& redirectResponse) override {
+ void willFollowRedirect(blink::WebURLLoader* loader,
+ blink::WebURLRequest& newRequest,
+ const blink::WebURLResponse& redirectResponse,
+ int64_t encodedDataLength) override {
EXPECT_TRUE(loader_);
EXPECT_EQ(loader_.get(), loader);
@@ -172,7 +172,8 @@ class TestWebURLLoaderClient : public blink::WebURLLoaderClient {
void didReceiveData(blink::WebURLLoader* loader,
const char* data,
int dataLength,
- int encodedDataLength) override {
+ int encodedDataLength,
+ int encodedBodyLength) override {
EXPECT_TRUE(loader_);
EXPECT_EQ(loader_.get(), loader);
// The response should have started, but must not have finished, or failed.
@@ -314,7 +315,7 @@ class WebURLLoaderImplTest : public testing::Test {
void DoReceiveData() {
EXPECT_EQ("", client()->received_data());
peer()->OnReceivedData(base::WrapUnique(new FixedReceivedData(
- kTestData, strlen(kTestData), strlen(kTestData))));
+ kTestData, strlen(kTestData), strlen(kTestData), strlen(kTestData))));
EXPECT_EQ(kTestData, client()->received_data());
}
@@ -346,8 +347,9 @@ class WebURLLoaderImplTest : public testing::Test {
}
void DoReceiveDataFtp() {
- peer()->OnReceivedData(base::WrapUnique(new FixedReceivedData(
- kFtpDirListing, strlen(kFtpDirListing), strlen(kFtpDirListing))));
+ auto size = strlen(kFtpDirListing);
+ peer()->OnReceivedData(base::WrapUnique(
+ new FixedReceivedData(kFtpDirListing, size, size, size)));
// The FTP delegate should modify the data the client sees.
EXPECT_NE(kFtpDirListing, client()->received_data());
}

Powered by Google App Engine
This is Rietveld 408576698