Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2105693003:
Vp9 decoder mft support for AMD apu/gpu (Closed)
|
Created:
4 years, 5 months ago by kplum Modified:
4 years, 4 months ago CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, piman+watch_chromium.org, posciak+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionVp9 decoder mft support for AMD apu/gpu
BUG=623962
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/344c65515e8f8c47e16332533c84314691545cfe
Cr-Commit-Position: refs/heads/master@{#414110}
Patch Set 1 #
Total comments: 9
Patch Set 2 : Change hardcoded values to an enum #
Total comments: 1
Patch Set 3 : Change enum to follow chromium style enum naming, remove unecessary media:: scope #
Total comments: 4
Patch Set 4 : Add microsoft to vpx vendor list, minor changes to condition checking and ran git cl format + git c… #Patch Set 5 : Merge with latest origin code #
Total comments: 4
Patch Set 6 : Comment update to reflect addition to the vpx vendor enum #
Total comments: 5
Patch Set 7 : Update comments to be more consistent. Change the VPX_VENDOR_ALL enum value to 0x07 from 0xff to al… #Patch Set 8 : rebase with latest origin #Patch Set 9 : Rebase once more to resolve cq issue #
Total comments: 2
Patch Set 10 : Make the MS option the default MFT #Patch Set 11 : I think I figured out the cq failure (CQ_INCLUDE_TRYBOTS in the change description was out of date) #Patch Set 12 : Update AUTHORS file #Patch Set 13 : Resolve merge conflict with AUTHORS #
Messages
Total messages: 80 (28 generated)
Description was changed from ========== Vp9 decoder mft support for AMD apu/gpu BUG=623962 ========== to ========== Vp9 decoder mft support for AMD apu/gpu BUG=623962 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
dalecurtis@chromium.org changed reviewers: + ananta@chromium.org, dalecurtis@chromium.org, jbauman@chromium.org
+jbauman,ananta
https://codereview.chromium.org/2105693003/diff/1/content/public/browser/gpu_... File content/public/browser/gpu_utils.cc (right): https://codereview.chromium.org/2105693003/diff/1/content/public/browser/gpu_... content/public/browser/gpu_utils.cc:53: gpu_preferences.enable_accelerated_vpx_decode = 2; = 0; https://codereview.chromium.org/2105693003/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/gpu_preferences.h (right): https://codereview.chromium.org/2105693003/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/gpu_preferences.h:53: uint32_t enable_accelerated_vpx_decode = 0; Use an enum for this instead. https://codereview.chromium.org/2105693003/diff/1/media/gpu/dxva_video_decode... File media/gpu/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/2105693003/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:1415: (profile == media::VP8PROFILE_ANY || Shouldn't need to change this. https://codereview.chromium.org/2105693003/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:1452: dll_path = dll_path.Append(kAMDVP9DecoderDLLName); Do you need to try to load this in DXVAVideoDecodeAccelerator::PreSandboxInitialization?
https://codereview.chromium.org/2105693003/diff/1/content/public/browser/gpu_... File content/public/browser/gpu_utils.cc (right): https://codereview.chromium.org/2105693003/diff/1/content/public/browser/gpu_... content/public/browser/gpu_utils.cc:53: gpu_preferences.enable_accelerated_vpx_decode = 2; On 2016/06/28 20:24:22, jbauman wrote: > = 0; I figured this would be brought up :) What would be the process to get this enabled by default for AMD? https://codereview.chromium.org/2105693003/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/gpu_preferences.h (right): https://codereview.chromium.org/2105693003/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/gpu_preferences.h:53: uint32_t enable_accelerated_vpx_decode = 0; On 2016/06/28 20:24:22, jbauman wrote: > Use an enum for this instead. Acknowledged. https://codereview.chromium.org/2105693003/diff/1/media/gpu/dxva_video_decode... File media/gpu/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/2105693003/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:1415: (profile == media::VP8PROFILE_ANY || On 2016/06/28 20:24:22, jbauman wrote: > Shouldn't need to change this. Acknowledged. https://codereview.chromium.org/2105693003/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:1452: dll_path = dll_path.Append(kAMDVP9DecoderDLLName); On 2016/06/28 20:24:22, jbauman wrote: > Do you need to try to load this in > DXVAVideoDecodeAccelerator::PreSandboxInitialization? Originally I thought I would, but then I noticed Intel's implementation didn't. I confirmed doing it here is functional with the sandbox enabled, but to be honest I couldn't figure out why...(is there a list of sandbox-exempt LoadLibrary directories for the decoding process somewhere?)
https://codereview.chromium.org/2105693003/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/gpu_preferences.h (right): https://codereview.chromium.org/2105693003/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/gpu_preferences.h:53: uint32_t enable_accelerated_vpx_decode = 0; On 2016/06/28 21:35:14, kyle.plumadore wrote: > On 2016/06/28 20:24:22, jbauman wrote: > > Use an enum for this instead. > > Acknowledged. If I try to add an enum type member to the structure I get compilation errors due to IPC templates: src\ipc\ipc_message_utils.h(90): error C2039: 'GetSize': is not a member of 'IPC::ParamTraits<Type>' src\ipc\ipc_message_utils.h(90): note: see declaration of 'IPC::ParamTraits<Type>' src\content\common\gpu_host_messages.h(87): note: see reference to function template instantiation 'void IPC::GetParamSize<gpu::GpuPreferences::VpxHardwareVendors>(base::PickleSizer *,const P &)' being compiled with [ P=gpu::GpuPreferences::VpxHardwareVendors ] It looks like every type used in IPC structures needs to have corresponding template implementations in src\ipc\ipc_message_utils.h, but I couldn't find any other case this is done for enums. I can keep the struct member type as uint32_t, but still use the enum values... Unless there is something else I'm missing?
On 2016/06/29 15:43:18, kyle.plumadore wrote: > https://codereview.chromium.org/2105693003/diff/1/gpu/command_buffer/service/... > File gpu/command_buffer/service/gpu_preferences.h (right): > > https://codereview.chromium.org/2105693003/diff/1/gpu/command_buffer/service/... > gpu/command_buffer/service/gpu_preferences.h:53: uint32_t > enable_accelerated_vpx_decode = 0; > On 2016/06/28 21:35:14, kyle.plumadore wrote: > > On 2016/06/28 20:24:22, jbauman wrote: > > > Use an enum for this instead. > > > > Acknowledged. > > If I try to add an enum type member to the structure I get compilation errors > due to IPC templates: > > src\ipc\ipc_message_utils.h(90): error C2039: 'GetSize': is not a member of > 'IPC::ParamTraits<Type>' > src\ipc\ipc_message_utils.h(90): note: see declaration of > 'IPC::ParamTraits<Type>' > src\content\common\gpu_host_messages.h(87): note: see reference to function > template instantiation 'void > IPC::GetParamSize<gpu::GpuPreferences::VpxHardwareVendors>(base::PickleSizer > *,const P &)' being compiled > with > [ > P=gpu::GpuPreferences::VpxHardwareVendors > ] > > It looks like every type used in IPC structures needs to have corresponding > template implementations in src\ipc\ipc_message_utils.h, but I couldn't find any > other case this is done for enums. I can keep the struct member type as > uint32_t, but still use the enum values... Unless there is something else I'm > missing? You can put a IPC_ENUM_TRAITS for it in content/common/gpu_host_messages.h. You might need to use IPC_ENUM_TRAITS_MAX_VALUE to pass the presubmit checks.
On 2016/06/28 21:35:14, kyle.plumadore wrote: > https://codereview.chromium.org/2105693003/diff/1/content/public/browser/gpu_... > File content/public/browser/gpu_utils.cc (right): > > https://codereview.chromium.org/2105693003/diff/1/content/public/browser/gpu_... > content/public/browser/gpu_utils.cc:53: > gpu_preferences.enable_accelerated_vpx_decode = 2; > On 2016/06/28 20:24:22, jbauman wrote: > > = 0; > > I figured this would be brought up :) What would be the process to get this > enabled by default for AMD? > We're trying to figure that out. Probably at a minimum we'll need some power benchmarks run to ensure that this is an improvement over software.
Change to use enum instead of hardcoded values for vendor support
https://codereview.chromium.org/2105693003/diff/20001/gpu/command_buffer/serv... File gpu/command_buffer/service/gpu_preferences.h (right): https://codereview.chromium.org/2105693003/diff/20001/gpu/command_buffer/serv... gpu/command_buffer/service/gpu_preferences.h:29: kVpxVendorNone = 0x00, Switch these to "VPX_VENDOR_NONE" style - see https://www.chromium.org/developers/coding-style
Change enum to follow chromium style enum naming, remove unecessary media:: scope
lgtm (still needs owners reviews)
Formatting is strange on this CL, can you run "git cl format" to make sure this is correct? https://codereview.chromium.org/2105693003/diff/40001/content/public/browser/... File content/public/browser/gpu_utils.cc (right): https://codereview.chromium.org/2105693003/diff/40001/content/public/browser/... content/public/browser/gpu_utils.cc:53: GetUintFromSwitch(command_line, switches::kEnableAcceleratedVpxDecode, This returns a boolean value that should be checked. https://codereview.chromium.org/2105693003/diff/40001/media/gpu/dxva_video_de... File media/gpu/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/2105693003/diff/40001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.cc:1412: } else if (enable_accelerated_vpx_decode_ != 0 && != unnecessary? https://codereview.chromium.org/2105693003/diff/40001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.cc:1443: if (decoder_dll == NULL && !decoder_dll https://codereview.chromium.org/2105693003/diff/40001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.cc:1460: if (decoder_dll == NULL) { !decoder_dll
Actually, I just added support in r404022 for using Microsoft's HMFT here. It would make sense to add VPX_VENDOR_MICROSOFT to this patch so we can enable or disable that independently.
Add microsoft to vpx vendor list, minor changes to condition checking and ran git cl format + git cl format media
I think you need to resync, your patch set does not have jbauman@'s recent changes.
Merged with latest
https://codereview.chromium.org/2105693003/diff/80001/content/public/common/c... File content/public/common/content_switches.cc (right): https://codereview.chromium.org/2105693003/diff/80001/content/public/common/c... content/public/common/content_switches.cc:1037: // 1=Intel Decoder only; 2=AMD Decoder only; 3=both Update comment. https://codereview.chromium.org/2105693003/diff/80001/media/gpu/dxva_video_de... File media/gpu/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/2105693003/diff/80001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.cc:1456: int program_files_key = base::DIR_PROGRAM_FILES; Move this above l.1446 then chain the vendor check via else instead of using !decoder_dll repeatedly? I.e. <set program_files_key> if (microsoft) { } else if (intel) { } etc.
https://codereview.chromium.org/2105693003/diff/80001/content/public/common/c... File content/public/common/content_switches.cc (right): https://codereview.chromium.org/2105693003/diff/80001/content/public/common/c... content/public/common/content_switches.cc:1037: // 1=Intel Decoder only; 2=AMD Decoder only; 3=both On 2016/07/11 18:52:40, DaleCurtis wrote: > Update comment. Acknowledged. https://codereview.chromium.org/2105693003/diff/80001/media/gpu/dxva_video_de... File media/gpu/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/2105693003/diff/80001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.cc:1456: int program_files_key = base::DIR_PROGRAM_FILES; On 2016/07/11 18:52:40, DaleCurtis wrote: > Move this above l.1446 then chain the vendor check via else instead of using > !decoder_dll repeatedly? I.e. > > <set program_files_key> > if (microsoft) { > } else if (intel) { > } > > etc. The reason it was done this way is to be able to enable multiple bits in enable_accelerated_vpx_decode_ simultaneously in order to try each of the decoders. I think this would be a valid case if we wanted to enable multiple decoders by default, since they all have platform limitations. If we only check the bitfields, we'll also have to know whether the current system supports the MS/Intel/Amd mft in order to only consider the correct bitfield value since none of the decoders will be available on all platforms.
Ah yeah, I forgot you wanted that. lgtm
Is there anyone else that still needs to review the change? When I run git cl
presubmit I get the following:
** Presubmit Messages **
Missing OWNER reviewers for these files:
content\common\gpu_host_messages.h
content\public\browser\gpu_utils.cc
content\public\common\content_switches.cc
Suggested OWNERS: (Use "git-cl owners" to interactively select owners.)
nasko@chromium.org
Add nasko@ to reviewers :)
Description was changed from ========== Vp9 decoder mft support for AMD apu/gpu BUG=623962 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Vp9 decoder mft support for AMD apu/gpu BUG=623962 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kyle.plumadore@amd.com changed reviewers: + nasko@chromium.org
On 2016/07/12 18:54:30, DaleCurtis wrote: > Add nasko@ to reviewers :) That makes sense. I'm not used to automated code review tools providing useful suggestions...
https://codereview.chromium.org/2105693003/diff/100001/content/common/gpu_hos... File content/common/gpu_host_messages.h (right): https://codereview.chromium.org/2105693003/diff/100001/content/common/gpu_hos... content/common/gpu_host_messages.h:36: (value <= gpu::GpuPreferences::VPX_VENDOR_ALL))) This is quite the range of possible values. Do we expect this enum to change often? I'd guess not and if that is the case, why not verify it is one of the possible values instead of the full range? https://codereview.chromium.org/2105693003/diff/100001/content/public/common/... File content/public/common/content_switches.cc (right): https://codereview.chromium.org/2105693003/diff/100001/content/public/common/... content/public/common/content_switches.cc:1037: // 1=Intel Decoder only; 2=AMD Decoder only; 4=Microsofts decoder only; 7=all The actual code has "VPX_VENDOR_ALL = 0xff", shouldn't we be keeping them in sync? https://codereview.chromium.org/2105693003/diff/100001/gpu/command_buffer/ser... File gpu/command_buffer/service/gpu_preferences.h (right): https://codereview.chromium.org/2105693003/diff/100001/gpu/command_buffer/ser... gpu/command_buffer/service/gpu_preferences.h:25: // support for accelerated Vpx decoding for various vendors nit: Start with capital letter and and with period. https://codereview.chromium.org/2105693003/diff/100001/gpu/command_buffer/ser... gpu/command_buffer/service/gpu_preferences.h:61: // bitmask - 0x1=Intel; 0x2=AMD; 0xff=all Missing comment for Microsoft.
https://codereview.chromium.org/2105693003/diff/100001/content/common/gpu_hos... File content/common/gpu_host_messages.h (right): https://codereview.chromium.org/2105693003/diff/100001/content/common/gpu_hos... content/common/gpu_host_messages.h:36: (value <= gpu::GpuPreferences::VPX_VENDOR_ALL))) On 2016/07/13 23:07:10, nasko wrote: > This is quite the range of possible values. Do we expect this enum to change > often? I'd guess not and if that is the case, why not verify it is one of the > possible values instead of the full range? I agree with the intent of your feedback but instead I changed the value for VPX_VENDOR_ALL to 0x07 since this enum is used as a bitfield and checking for all valid values would be verbose due to the combinations.
LGTM
You have enough approvals to submit this. If you don't here from a reviewer in less than 48 hours feel free to ping them via e-mail or proceed without them if you have sufficient approval already.
Sorry for the delay, I got snagged on some internal issues which prevented progress on this. I rebased to the latest. Seems Intel support was removed. Our MFT outperforms the MS MFT on the AMD systems which we ship the MFT on (plus ours is available on win7), so we think there is still a good reason to support both. If everyone is fine, I'll go ahead and select the commit box.
still lgtm
The CQ bit was checked by kyle.plumadore@amd.com
The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org, nasko@chromium.org Link to the patchset: https://codereview.chromium.org/2105693003/#ps140001 (title: "rebase with latest origin")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Your CL was about to rely on recently removed CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
tryserver.chromium.linux
tryserver.chromium.mac
tryserver.chromium.win
For more details, see http://crbug.com/617627.
The CQ bit was checked by kyle.plumadore@amd.com
The patchset sent to the CQ was uploaded after l-g-t-m from dalecurtis@chromium.org, jbauman@chromium.org, nasko@chromium.org Link to the patchset: https://codereview.chromium.org/2105693003/#ps160001 (title: "Rebase once more to resolve cq issue")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Your CL was about to rely on recently removed CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
tryserver.chromium.linux
tryserver.chromium.mac
tryserver.chromium.win
For more details, see http://crbug.com/617627.
https://codereview.chromium.org/2105693003/diff/160001/content/public/browser... File content/public/browser/gpu_utils.cc (right): https://codereview.chromium.org/2105693003/diff/160001/content/public/browser... content/public/browser/gpu_utils.cc:51: uint32_t enable_accelerated_vpx_decode_val = This needs to be VPX_VENDOR_MICROSOFT. https://codereview.chromium.org/2105693003/diff/160001/gpu/command_buffer/ser... File gpu/command_buffer/service/gpu_preferences.h (right): https://codereview.chromium.org/2105693003/diff/160001/gpu/command_buffer/ser... gpu/command_buffer/service/gpu_preferences.h:62: VpxDecodeVendors enable_accelerated_vpx_decode = VPX_VENDOR_NONE; This should be VPX_VENDOR_MICROSOFT.
The CQ bit was checked by kyle.plumadore@amd.com
The patchset sent to the CQ was uploaded after l-g-t-m from dalecurtis@chromium.org, jbauman@chromium.org, nasko@chromium.org Link to the patchset: https://codereview.chromium.org/2105693003/#ps180001 (title: "Make the MS option the default MFT")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Your CL was about to rely on recently removed CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
tryserver.chromium.linux
tryserver.chromium.mac
tryserver.chromium.win
For more details, see http://crbug.com/617627.
Description was changed from ========== Vp9 decoder mft support for AMD apu/gpu BUG=623962 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Vp9 decoder mft support for AMD apu/gpu BUG=623962 ==========
Description was changed from ========== Vp9 decoder mft support for AMD apu/gpu BUG=623962 ========== to ========== Vp9 decoder mft support for AMD apu/gpu BUG=623962 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by kyle.plumadore@amd.com
The patchset sent to the CQ was uploaded after l-g-t-m from dalecurtis@chromium.org, jbauman@chromium.org, nasko@chromium.org Link to the patchset: https://codereview.chromium.org/2105693003/#ps200001 (title: "I think I figured out the cq failure (CQ_INCLUD_TRYBOTS in the change description)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
The author kyle.plumadore@amd.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
The CQ bit was checked by kyle.plumadore@amd.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
You need to update the AUTHORS file now: kyle.plumadore@amd.com is not in AUTHORS file. If you are a new contributor, please visit http://www.chromium.org/developers/contributing-code and read the "Legal" section If you are a chromite, verify the contributor signed the CLA.
The CQ bit was checked by kyle.plumadore@amd.com
The patchset sent to the CQ was uploaded after l-g-t-m from dalecurtis@chromium.org, jbauman@chromium.org, nasko@chromium.org Link to the patchset: https://codereview.chromium.org/2105693003/#ps220001 (title: "Update AUTHORS file")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by kyle.plumadore@amd.com
The patchset sent to the CQ was uploaded after l-g-t-m from dalecurtis@chromium.org, jbauman@chromium.org, nasko@chromium.org Link to the patchset: https://codereview.chromium.org/2105693003/#ps240001 (title: "Resolve merge conflict with AUTHORS")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
On 2016/08/24 16:22:11, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) It looks like this failure is unrelated to my change?
Probably, feel free to click cq again in that case.
The CQ bit was checked by kyle.plumadore@amd.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #13 (id:240001)
Message was sent while issue was closed.
Description was changed from ========== Vp9 decoder mft support for AMD apu/gpu BUG=623962 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Vp9 decoder mft support for AMD apu/gpu BUG=623962 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/344c65515e8f8c47e16332533c84314691545cfe Cr-Commit-Position: refs/heads/master@{#414110} ==========
Message was sent while issue was closed.
Patchset 13 (id:??) landed as https://crrev.com/344c65515e8f8c47e16332533c84314691545cfe Cr-Commit-Position: refs/heads/master@{#414110} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
