[Editing][Codehealth] Rewrite user-select-all-selection.html with assert_selection.

[Editing][Codehealth] Rewrite user-select-all-selection.html with assert_selection.

This improves readability and maintainability.
Plus, change assert_selection.js to get testee document offset for eventSender and
 remove focus existing check to permit no selection in sample text.

TEST=editing/selection/user-select/user-select-all.html

Committed: https://crrev.com/364374c4d437115a136895df9e1cdcdbc9940a53
Cr-Commit-Position: refs/heads/master@{#403647}

[yoichio, 2016-06-29 02:18:54]

Description was changed from

==========
all tests

BUG=
==========

to

==========
[Editing][Codehealth] Rewrite user-select-all-selection.html with
assert_selection.

This improves readability and maintainability.
Plus, change assert_selection.js to get testee document offset for eventSender
and
 remove focus existing check to permit no selection in sample text.

TEST=editing/selection/user-select/user-select-all.html
==========

[yoichio, 2016-06-29 02:18:54]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2016-06-30 03:47:37]

https://codereview.chromium.org/2105663002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/assert_selection.js (right):

https://codereview.chromium.org/2105663002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/assert_selection.js:520:
this.selection_.document.offsetLeft = this.iframe_.offsetLeft;
Not sure about these changes.
Document doesn't have |offsetLeft| and |offsetTop| properties.

https://codereview.chromium.org/2105663002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/assert_selection.js:539: if (focusMarker
< 0 && anchorMarker >= 0) {
We should have another CL for this change to explicitly state
|assert_selection()| for this case.

https://codereview.chromium.org/2105663002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all.html
(right):

https://codereview.chromium.org/2105663002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all.html:56:

nit: We don't need to have an extra blank line.
It seems that it is better to have another test() for cases using eventSender.

https://codereview.chromium.org/2105663002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all.html:95:
assert_selection(
nit: We don't need to have an extra blank line.
It seems that it is better to have another test() for cases for
selectAllChildren()

[yoichio, 2016-06-30 05:52:08]

Patchset #1 (id:1) has been deleted

[yoichio, 2016-07-04 06:25:22]

Patchset #2 (id:40001) has been deleted

[yoichio, 2016-07-04 06:28:17]

https://codereview.chromium.org/2105663002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/assert_selection.js (right):

https://codereview.chromium.org/2105663002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/assert_selection.js:520:
this.selection_.document.offsetLeft = this.iframe_.offsetLeft;
On 2016/06/30 03:47:37, Yosi_UTC9 wrote:
> Not sure about these changes.
> Document doesn't have |offsetLeft| and |offsetTop| properties.

That's because we need iframe offset to use eventSender.mouseMove.

https://codereview.chromium.org/2105663002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all.html
(right):

https://codereview.chromium.org/2105663002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all.html:56:

On 2016/06/30 03:47:37, Yosi_UTC9 wrote:
> nit: We don't need to have an extra blank line.
> It seems that it is better to have another test() for cases using eventSender.

Done.

https://codereview.chromium.org/2105663002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all.html:95:
assert_selection(
On 2016/06/30 03:47:37, Yosi_UTC9 wrote:
> nit: We don't need to have an extra blank line.
> It seems that it is better to have another test() for cases for
> selectAllChildren()

Done.

[yosin_UTC9, 2016-07-04 07:13:01]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-07-04 07:13:02]

lgtm

[commit-bot: I haz the power, 2016-07-04 07:13:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 07:42:01]

Description was changed from

==========
[Editing][Codehealth] Rewrite user-select-all-selection.html with
assert_selection.

This improves readability and maintainability.
Plus, change assert_selection.js to get testee document offset for eventSender
and
 remove focus existing check to permit no selection in sample text.

TEST=editing/selection/user-select/user-select-all.html
==========

to

==========
[Editing][Codehealth] Rewrite user-select-all-selection.html with
assert_selection.

This improves readability and maintainability.
Plus, change assert_selection.js to get testee document offset for eventSender
and
 remove focus existing check to permit no selection in sample text.

TEST=editing/selection/user-select/user-select-all.html
==========

[commit-bot: I haz the power, 2016-07-04 07:42:01]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-07-04 07:44:13]

Description was changed from

==========
[Editing][Codehealth] Rewrite user-select-all-selection.html with
assert_selection.

This improves readability and maintainability.
Plus, change assert_selection.js to get testee document offset for eventSender
and
 remove focus existing check to permit no selection in sample text.

TEST=editing/selection/user-select/user-select-all.html
==========

to

==========
[Editing][Codehealth] Rewrite user-select-all-selection.html with
assert_selection.

This improves readability and maintainability.
Plus, change assert_selection.js to get testee document offset for eventSender
and
 remove focus existing check to permit no selection in sample text.

TEST=editing/selection/user-select/user-select-all.html

Committed: https://crrev.com/364374c4d437115a136895df9e1cdcdbc9940a53
Cr-Commit-Position: refs/heads/master@{#403647}
==========

[commit-bot: I haz the power, 2016-07-04 07:44:14]

Patchset 2 (id:??) landed as
https://crrev.com/364374c4d437115a136895df9e1cdcdbc9940a53
Cr-Commit-Position: refs/heads/master@{#403647}