Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Side by Side Diff: tools/perf/PRESUBMIT.py

Issue 2105653005: [Perf] Remove Windows from CQ_EXTRA_TRYBOTS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 The Chromium Authors. All rights reserved. 1 # Copyright 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for changes affecting tools/perf/. 5 """Presubmit script for changes affecting tools/perf/.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 rietveld_obj = cl.RpcServer() 120 rietveld_obj = cl.RpcServer()
121 issue = cl.issue 121 issue = cl.issue
122 original_description = rietveld_obj.get_description(issue) 122 original_description = rietveld_obj.get_description(issue)
123 if not benchmarks_modified or re.search( 123 if not benchmarks_modified or re.search(
124 r'^CQ_EXTRA_TRYBOTS=.*', original_description, re.M | re.I): 124 r'^CQ_EXTRA_TRYBOTS=.*', original_description, re.M | re.I):
125 return [] 125 return []
126 126
127 results = [] 127 results = []
128 bots = [ 128 bots = [
129 'android_s5_perf_cq', 129 'android_s5_perf_cq',
130 'winx64_10_perf_cq',
131 'mac_retina_perf_cq', 130 'mac_retina_perf_cq',
132 'linux_perf_cq' 131 'linux_perf_cq'
133 ] 132 ]
134 bots = ['tryserver.chromium.perf:%s' % s for s in bots] 133 bots = ['tryserver.chromium.perf:%s' % s for s in bots]
135 bots_string = ';'.join(bots) 134 bots_string = ';'.join(bots)
136 description = original_description 135 description = original_description
137 description += '\nCQ_EXTRA_TRYBOTS=%s' % bots_string 136 description += '\nCQ_EXTRA_TRYBOTS=%s' % bots_string
138 results.append(output_api.PresubmitNotifyResult( 137 results.append(output_api.PresubmitNotifyResult(
139 'Automatically added Perf trybots to run Telemetry benchmarks on CQ.')) 138 'Automatically added Perf trybots to run Telemetry benchmarks on CQ.'))
140 139
141 if description != original_description: 140 if description != original_description:
142 rietveld_obj.update_description(issue, description) 141 rietveld_obj.update_description(issue, description)
143 142
144 return results 143 return results
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698