Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2216)

Unified Diff: ash/mus/window_manager_application.h

Issue 2105653003: Fixes shutdown race in mash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/mus/window_manager.cc ('k') | ash/mus/window_manager_application.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/mus/window_manager_application.h
diff --git a/ash/mus/window_manager_application.h b/ash/mus/window_manager_application.h
index 16a51bc7c0b09e86f6ec543ccd2a40bf45530449..ceb88aeac9d8c2fc20ab33d84a1bf2b93e00e300 100644
--- a/ash/mus/window_manager_application.h
+++ b/ash/mus/window_manager_application.h
@@ -10,7 +10,7 @@
#include <memory>
#include <set>
-#include "ash/mus/root_windows_observer.h"
+#include "ash/mus/window_manager_observer.h"
#include "ash/public/interfaces/shelf_layout.mojom.h"
#include "ash/public/interfaces/user_window_controller.mojom.h"
#include "base/macros.h"
@@ -49,7 +49,7 @@ class WindowManagerApplication
public shell::InterfaceFactory<mojom::UserWindowController>,
public shell::InterfaceFactory<::mus::mojom::AcceleratorRegistrar>,
public mash::session::mojom::ScreenlockStateListener,
- public RootWindowsObserver {
+ public WindowManagerObserver {
public:
WindowManagerApplication();
~WindowManagerApplication() override;
@@ -58,9 +58,6 @@ class WindowManagerApplication
WindowManager* window_manager() { return window_manager_.get(); }
- // TODO(sky): figure out right place for this code.
- void OnAccelerator(uint32_t id, const ui::Event& event);
-
mash::session::mojom::Session* session() { return session_.get(); }
private:
@@ -94,7 +91,7 @@ class WindowManagerApplication
// session::mojom::ScreenlockStateListener:
void ScreenlockStateChanged(bool locked) override;
- // RootWindowsObserver:
+ // WindowManagerObserver:
void OnRootWindowControllerAdded(RootWindowController* controller) override;
void OnWillDestroyRootWindowController(
RootWindowController* controller) override;
« no previous file with comments | « ash/mus/window_manager.cc ('k') | ash/mus/window_manager_application.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698