Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: ash/mus/window_manager.h

Issue 2105653003: Fixes shutdown race in mash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/mus/test/wm_test_helper.cc ('k') | ash/mus/window_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/mus/window_manager.h
diff --git a/ash/mus/window_manager.h b/ash/mus/window_manager.h
index a922d52291fa3523b9e3c1041c509c474d475690..93f6dfcff8feb4cd12a2fb7e7e81f3b93407aee6 100644
--- a/ash/mus/window_manager.h
+++ b/ash/mus/window_manager.h
@@ -31,9 +31,8 @@ namespace ash {
namespace mus {
class RootWindowController;
-class RootWindowsObserver;
class ShadowController;
-class WindowManagerApplication;
+class WindowManagerObserver;
class WmShellMus;
class WmLookupMus;
class WmTestHelper;
@@ -46,8 +45,7 @@ class WindowManager : public ::mus::WindowManagerDelegate,
public ::mus::WindowObserver,
public ::mus::WindowTreeClientDelegate {
public:
- WindowManager(WindowManagerApplication* window_manager_app,
- shell::Connector* connector);
+ explicit WindowManager(shell::Connector* connector);
~WindowManager() override;
void Init(::mus::WindowTreeClient* window_tree_client);
@@ -68,8 +66,8 @@ class WindowManager : public ::mus::WindowManagerDelegate,
std::set<RootWindowController*> GetRootWindowControllers();
- void AddRootWindowsObserver(RootWindowsObserver* observer);
- void RemoveRootWindowsObserver(RootWindowsObserver* observer);
+ void AddObserver(WindowManagerObserver* observer);
+ void RemoveObserver(WindowManagerObserver* observer);
private:
friend class WmTestHelper;
@@ -105,9 +103,6 @@ class WindowManager : public ::mus::WindowManagerDelegate,
const display::Display& display) override;
void OnAccelerator(uint32_t id, const ui::Event& event) override;
- // TODO(sky): this is unfortunate, remove.
- WindowManagerApplication* window_manager_app_;
-
shell::Connector* connector_;
::mus::WindowTreeClient* window_tree_client_ = nullptr;
@@ -118,7 +113,7 @@ class WindowManager : public ::mus::WindowManagerDelegate,
std::set<std::unique_ptr<RootWindowController>> root_window_controllers_;
- base::ObserverList<RootWindowsObserver> root_windows_observers_;
+ base::ObserverList<WindowManagerObserver> observers_;
std::unique_ptr<display::Screen> screen_;
« no previous file with comments | « ash/mus/test/wm_test_helper.cc ('k') | ash/mus/window_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698