Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2105613002: X87: [builtins] Introduce proper Float64Cos and Float64Sin. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Introduce proper Float64Cos and Float64Sin. port c781e83194031b337f8eafb42588a2e3d7440782 (r37072) original commit message: Import base::ieee754::cos() and base::ieee754::sin() from fdlibm and introduce Float64Cos and Float64Sin TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.cos() and Math.sin() as TurboFan builtins and use those operators to also inline Math.cos() and Math.sin() into optimized TurboFan functions. BUG= Committed: https://crrev.com/3bc1a842275932c16aae63d5178b060fec658cd1 Cr-Commit-Position: refs/heads/master@{#37304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -14 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +17 lines, -5 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 4 chunks +22 lines, -0 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 2 chunks +35 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-06-28 02:02:40 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-06-28 02:41:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105613002/1
4 years, 5 months ago (2016-06-28 02:42:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 03:06:45 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 03:07:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3bc1a842275932c16aae63d5178b060fec658cd1
Cr-Commit-Position: refs/heads/master@{#37304}

Powered by Google App Engine
This is Rietveld 408576698