Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2105603002: mingw64 fix (Closed)

Created:
4 years, 5 months ago by fbarchard1
Modified:
4 years, 5 months ago
Reviewers:
harryjin, wiiaboo
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

mingw64 fix - guard row_win.cc against mingw build. The old guard only checked for defined(_M_X64) which is defined by mingw64. Add a test for defined(_MSC_VER) which is defined for clangcl and visual c but not mingw. mingw should use row_gcc.cc for both 32 and 64 bit. R=harryjin@google.com BUG=webm:1252, libyuv:613 TEST=local gcc/clang builds on linux tested and try bots for others. Committed: https://chromium.googlesource.com/libyuv/libyuv/+/2f101fdbda4a6cb205ea3bd90a6a6bc696ea5383

Patch Set 1 #

Patch Set 2 : row.h also check for mscver for 64 bit #

Patch Set 3 : git cl try #

Patch Set 4 : row.h fix for mingw as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/row.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
M source/row_win.cc View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
fbarchard1
4 years, 5 months ago (2016-06-28 00:59:38 UTC) #1
wiiaboo
lgtm LGTM, tested on MinGW GCC i686 and x86_64.
4 years, 5 months ago (2016-06-28 12:27:28 UTC) #8
fbarchard1
4 years, 5 months ago (2016-06-28 17:21:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
2f101fdbda4a6cb205ea3bd90a6a6bc696ea5383 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698