Issue 2105593003: Generate go files in the go/src directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2105593003: Generate go files in the go/src directory. (Closed)

Created:
4 years, 5 months ago by azani

Modified:
4 years, 5 months ago

Reviewers:
kulakowski

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Generate go files in the go/src directory. Undoes a change that was never supposed to make it in a CL. R=kulakowski@chromium.org, kulakowski Committed: https://chromium.googlesource.com/external/mojo/+/e902fed4ddf5f2d9946fa0cf4f177b0a5176ca93

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	mojo/public/tools/bindings/generators/mojom_go_generator.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kulakowski

On 2016/06/28 20:50:43, azani wrote: lgtm Just cleanly rebuilt, my issue went away.

4 years, 5 months ago (2016-06-28 20:56:14 UTC) #2

azani

4 years, 5 months ago (2016-06-28 21:02:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e902fed4ddf5f2d9946fa0cf4f177b0a5176ca93 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages