Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 2105593002: MSE: Experimental support for customizing live seekable range (Closed)

Created:
4 years, 5 months ago by wolenetz
Modified:
4 years, 5 months ago
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, haraken, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MSE: Experimental support for customizing live seekable range Adds {set,clear}LiveSeekableRange methods to MediaSource IDL, with implementations corresponding to the recent MSE spec addition of these methods [1]. These methods are behind the MediaSourceExperimental RuntimeEnabled flag until intent to ship is approved in a later milestone. Intent to implement thread is at [2]. [1] https://github.com/w3c/media-source/pull/92 [2] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/2znjjhg7KiY BUG=623698 TEST=passes upstream w3c/wpt mediasource-liveseekable.html test in PR at https://github.com/w3c/web-platform-tests/pull/3184 R=chcunningham@chromium.org,mlamouri@chromium.org Committed: https://crrev.com/b2f2d65c0068345ba8d5ee9462bab35463c94475 Cr-Commit-Position: refs/heads/master@{#402519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/MediaSource.h View 3 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/MediaSource.cpp View 6 chunks +62 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/MediaSource.idl View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
wolenetz
Please take a look: chcunningham@: everything (as MSE owner) mlamouri@: everything from Blink perspective (things ...
4 years, 5 months ago (2016-06-28 01:03:31 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105593002/1
4 years, 5 months ago (2016-06-28 01:03:34 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/246374)
4 years, 5 months ago (2016-06-28 02:29:16 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105593002/1
4 years, 5 months ago (2016-06-28 03:25:00 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/246473)
4 years, 5 months ago (2016-06-28 06:22:59 UTC) #10
mlamouri (slow - plz ping)
lgtm
4 years, 5 months ago (2016-06-28 13:36:32 UTC) #11
mlamouri (slow - plz ping)
(it's missing tests but I see there are some in WPT and that's super great! ...
4 years, 5 months ago (2016-06-28 13:36:53 UTC) #12
chcunningham
lgtm
4 years, 5 months ago (2016-06-28 17:17:21 UTC) #13
wolenetz
On 2016/06/28 13:36:53, Mounir Lamouri (slow) wrote: > (it's missing tests but I see there ...
4 years, 5 months ago (2016-06-28 18:17:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105593002/1
4 years, 5 months ago (2016-06-28 18:19:12 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 20:19:13 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 20:22:38 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2f2d65c0068345ba8d5ee9462bab35463c94475
Cr-Commit-Position: refs/heads/master@{#402519}

Powered by Google App Engine
This is Rietveld 408576698